Improve the dark and light theme and move the values in the css handler #3621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the dark and light theme and move the values in the css handler
buchen
pushed a commit
that referenced
this pull request
Nov 1, 2023
Issue: #3621 #3614 Signed-off-by: Nirus2000 <[email protected]> [removed unnecessary changes due to format changes; rebased to master] Signed-off-by: Andreas Buchen <[email protected]>
|
merged. That will give more flexibility to change colors in the future. If you look at the pull request: I have kept the original formatting of the plugin.xml so that it is clear what has been changed with this commit. I also removed some of the comments. If it is an implementation of the interface, I think it is okay to have the description in the interface. I also removed the attribute descriptions - if it is just straight forward attributes, no one is looking at the description anyway and it just uses up precious space. The other comments I kept. |
Nirus2000
deleted the
Improve-the-dark-and-light-theme-and-move-the-values-in-the-css-handler
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the dark and light theme and move the values in the css handler