Enable shared EFS volume for all services #1300
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosefmih
reviewed
May 22, 2024
yosefmih
reviewed
May 22, 2024
yosefmih
reviewed
May 22, 2024
yosefmih
approved these changes
May 22, 2024
d-g-town
reviewed
May 22, 2024
| @@ -323,8 +323,11 @@ spec: | |||
| {{ if .Values.awsEfsStorage }} | |||
| volumeMounts: | |||
| {{- range $v := .Values.awsEfsStorage }} | |||
| - name: efs-{{ $.Values.fullnameOverride }} | |||
| - name: {{ $v.name }} | |||
There was a problem hiding this comment.
Can you keep this name the same?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for adding a shared EFS volumes on all types of services.
If this is enabled in the dashboard, the EFS volume will be mounted to all services and jobs under the same path. I changed the mount path to be the same as the app name (release name) so that it matches what is being displayed on the dashboard.
For compatibility reasons, the web service will have two mountpaths for the EFS volume: