move ccp connection to cc link #4616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MauAraujo
reviewed
May 7, 2024
| setErrorMessage(err.message); | ||
| setLoading(false); | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| onCreate(); |
There was a problem hiding this comment.
Calling onCreate here also causes the modal to close even when there are errors, I would just wrap everything into a try catch block and only call OnCreate and setLoading(false) after the api calls have completed
|
|
||
| // create cluster on first payment setup for sandbox | ||
| if (currentProject?.sandbox_enabled) { | ||
| await api.connectProjectToCluster( |
There was a problem hiding this comment.
If a user adds another payment method, this will create another cluster connection right? Should we limit to one credit card?
| { project_id: currentProject.id } | ||
| ) | ||
| }) | ||
| .catch((err: any) => { |
There was a problem hiding this comment.
The payment method will be added to Stripe even if this call fails, is there another way to create the cluster if that happens?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POR-
What does this PR do?