Trailer integration #679
Open
Trailer integration #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| setTrailer: function() { | ||
| var model = this; | ||
| App.findTrailer(model.get('title'), function(data) { | ||
| model.set('trailer', data); |
There was a problem hiding this comment.
I have a question about asynchronous programming. If findTrailer took forever to get a response back, and you wrote var trailer = model.get('trailer') right after this.setTrailer(); on line 75, would trailer be undefined? How can you avoid that?
|
this api could get false-positives |
|
Duplicate: #344 |
|
Hey! Thanks for the contribution! Unfortunately this project is no longer being maintained, but it is being forkd by the very reputable folks at YiFy, so please resubmit your pull request to: https://github.com/Yify/popcorn-app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting trailers trough trailersapi.com and embedding them trough video.js
Not really 100% accurate but close enough..