-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental message passing based pool implementation #4585
base: main
Are you sure you want to change the base?
Conversation
@dipinhora if I give you access to the perftesting machine, would you be willing to do performance comparisons? |
I think this would benefit from having stress tests that run using this. Thoughts on the value of adding those @dipinhora ? |
sure, but i don't think it's ready for any real performance comparisons yet.. i was hoping to get this initial version merged as an
yes, it would be great to put this through some torture.. not sure that the current nightly stress test a mixed enough workload in general but is definitely a great start.. the only thing that might be worth considering is the potential for noise if the stress tests find issues/cause failures in this.. |
@dipinhora email me a public key to install on the test machine. |
@dipinhora when you have a chance, you should rebase against main which now has updated ubuntu24 builders across the board. |
63b9aaa
to
dd0ffe3
Compare
done |
@dipinhora that failure for the #4582 regression appears to be real. Not sure if it was caused by this change or if there's a sneaky issue still that wasn't caught before. |
This is an alternative memory pool implementation that handles returning allocations back to the thread that allocated them via message passing (yes, the idea was shamelessly stolen from verona). It currently has a number of limitations and inefficiencies and hasn't been performance tested to see if it is better or worse than the default pool implementation. But it is in a stable enough place that it seems to function correctly.
dd0ffe3
to
44b6768
Compare
This is an alternative memory pool implementation that handles returning allocations back to the thread that allocated them via message passing (yes, the idea was shamelessly stolen from verona).
It currently has a number of limitations and inefficiencies and hasn't been performance tested to see if it is better or worse than the default pool implementation. But it is in a stable enough place that it seems to function correctly.