-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pileks/feat/multidocs #317
Conversation
|
||
#### What's going on here? | ||
|
||
Using the Polywrap Client, we are invoking the `sha3_256` method of a Wrap found under the [WRAP URI](/concepts/uris) `wrapscan.io/polywrap/[email protected]` called the SHA3 Wrap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: we can reduce the amount of duplicate text in these docs by using snippets for the contents (and not just the code)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually looking into markdown partials for this kind of thing!
No need to use snippets when Docusaurus' MDX capabilities allow for partial views.
3 more NITs:
All of this could totally be done in a separate PR. I overall love the look and feel of everything 🔥 let's keep iterating and improving on this! It feels much farther along than before! |
Agreed 100%
Do you mean the wraps we're importing? It does seem that, from what I've gathered talking to you guys, we should probably actually unify all template apps to import the same wrap/do the same thing (maybe even something as dumb as SHA3 invocation). I think that some of the app templates currently are a bit "gratuitous" in the sense that they are basically full apps instead of just giving people a good starting point with a simple example. We can even keep the more complex templates, as we do have support for pulling templates from non-default sources. I believe such a move (unified starter examples) would allow us to unify our documentation more, and what are templates but a live documentation example. Let me know what your thoughts on this are and maybe we can discuss this further with all other core devs on ACDC.
Huh, so actually adding a "more advanced" tutorial here. I'm generally OK with that, at least for a very simple example. The thing is that we'd also have to add the concept of sub-invocation here (which shouldn't be too hard to explain). |
Includes changes to
Quick Start
andCLI
, adding support for all of our client languages.Prerequisites:
Remaining tasks:
polywrap
ondocs.rs
for the Reference documentation in the "Clients" section