Fix default threshold in motion #9419
Conversation
From the description, the default motion threshold should be "50%+1". However the old implementation was `ceil(50% council)`. When the council has an even member size, it produces 50% council, but not 50%+1. This commit fixes it.
|
I really do appreciate the PR (especially since the other has been stuck in limbo forever), it is just that the underlying issues remain. The bigger issue I see with only this part is that it also has effects on e.g. treasury and everywhere council is involved. And then the thresholds has the same issue everywhere else as well, e.g. tech comm was also a problematic (issue logged) case. The only outstanding issue (merge master in again this morning) of #6924 is that I have not had a gap to configured a dev chain with even thresholds to test. So if there is an ok from somewhere that "it works", it is reasonable to merge. TL;DR Holdup on the linked PR is not code, rather "it does what it is supposed to in tests". |
|
Thanks for the confirmation. Moving to #6924 and I'm happy to provide help. |
From the description, the default motion threshold should be "50%+1". However the old implementation was
ceil(50% council). When the council has an even member size, it produces 50% council, but not 50%+1. This commit fixes it.