Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix payout UI for staking #11035

Merged
merged 2 commits into from
Nov 4, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/page-staking/src/Payouts/PayButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,25 @@ function createExtrinsics (api: ApiPromise, payout: PayoutValidator | PayoutVali
if (!Array.isArray(payout)) {
const { eras, validatorId } = payout;

if (eras.every((e) => e.isClaimed)) {
return null;
}

return eras.length === 1
? [api.tx.staking.payoutStakers(validatorId, eras[0].era)]
: createStream(api, eras.map((era): SinglePayout => ({ era: era.era, validatorId })));
} else if (payout.length === 1) {
if (payout[0].eras.every((e) => e.isClaimed)) {
return null;
}

return createExtrinsics(api, payout[0]);
}

if (!payout.some((p) => p.eras.some((e) => !e.isClaimed))) {
return null;
}

return createStream(api, payout.reduce((payouts: SinglePayout[], { eras, validatorId }): SinglePayout[] => {
eras.forEach(({ era }): void => {
payouts.push({ era, validatorId });
Expand Down Expand Up @@ -76,7 +88,7 @@ function PayButton ({ className, isAll, isDisabled, payout }: Props): React.Reac
);
}, [api, payout]);

const isPayoutEmpty = !payout || (Array.isArray(payout) && payout.length === 0);
const isPayoutEmpty = !payout || (Array.isArray(payout) && !payout.some((p) => p.eras.some((e) => !e.isClaimed))) || (Array.isArray(payout) && payout.length === 0);

return (
<>
Expand Down
2 changes: 1 addition & 1 deletion packages/page-staking/src/Payouts/Stash.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function Stash ({ className = '', historyDepth, payout: { available, rewards, st

useEffect((): void => {
rewards && setEraInfo({
eraStr: createErasString(rewards.map(({ era }) => era)),
eraStr: createErasString(rewards.filter(({ isClaimed }) => !isClaimed).map(({ era }) => era)),
oldestEra: rewards[0]?.era
});
}, [rewards]);
Expand Down
2 changes: 1 addition & 1 deletion packages/page-staking/src/Payouts/Validator.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ interface State {
}

function extractState (payout: PayoutValidator): State {
const eraStr = createErasString(payout.eras.map(({ era }) => era));
const eraStr = createErasString(payout.eras.filter(({ isClaimed }) => !isClaimed).map(({ era }) => era));
const nominators = payout.eras.reduce((nominators: Record<string, BN>, { stashes }): Record<string, BN> => {
Object.entries(stashes).forEach(([stashId, value]): void => {
if (nominators[stashId]) {
Expand Down
5 changes: 4 additions & 1 deletion packages/page-staking/src/Payouts/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
} else {
entry.eras.push({
era: reward.era,
isClaimed: reward.isClaimed,

Check failure on line 63 in packages/page-staking/src/Payouts/index.tsx

View workflow job for this annotation

GitHub Actions / pr (lint)

Unsafe assignment of an `any` value
stashes: { [stashId]: value }
});
}
Expand All @@ -71,6 +72,7 @@
available: value,
eras: [{
era: reward.era,
isClaimed: reward.isClaimed,

Check failure on line 75 in packages/page-staking/src/Payouts/index.tsx

View workflow job for this annotation

GitHub Actions / pr (lint)

Unsafe assignment of an `any` value
stashes: { [stashId]: value }
}],
total,
Expand All @@ -97,6 +99,7 @@
stashId
}))
.filter(({ available }) => !available.isZero())
.filter(({ rewards }) => rewards.some((r) => !r.isClaimed))
.sort((a, b) => b.available.cmp(a.available));
}

Expand Down Expand Up @@ -270,7 +273,7 @@
/>
))}
</Table>
{(myStashesIndex === 1) && !isLoadingRewards && validators && (validators.length !== 0) && (
{(myStashesIndex === 1) && !isLoadingRewards && validators && (validators.length !== 0) && validators.filter(({ eras }) => eras.some((e) => !e.isClaimed)).length > 0 && (
<Table
footer={footerVal}
header={headerValidatorsRef.current}
Expand Down
1 change: 1 addition & 0 deletions packages/page-staking/src/Payouts/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import type { BN } from '@polkadot/util';
export interface PayoutEraValidator {
era: EraIndex;
stashes: Record<string, Balance>;
isClaimed: boolean;
}

export interface PayoutValidator {
Expand Down
1 change: 1 addition & 0 deletions packages/react-hooks/src/useOwnEraRewards.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@
allRewards[stashId].push({
era,
eraReward: eraRewards.eraReward,
isClaimed: false,

Check failure on line 90 in packages/react-hooks/src/useOwnEraRewards.ts

View workflow job for this annotation

GitHub Actions / pr (build:code)

Object literal may only specify known properties, and 'isClaimed' does not exist in type 'DeriveStakerReward'.
isEmpty: false,
isValidator: true,
nominating: [],
Expand Down
Loading