Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Files(IPFS) module status link and download link #10181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Files(IPFS) module status link and download link #10181

wants to merge 1 commit into from

Conversation

XueMoMo
Copy link
Contributor

@XueMoMo XueMoMo commented Jan 15, 2024

  1. The old download link is no longer available, so we should use cf-ipfs.com
  2. Fix the status link to link to specific file information

@itsbirdo
Copy link

@TarikGul are you able to look at this please sir ?

TarikGul
TarikGul requested changes May 17, 2024
View reviewed changes
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question. Otherwise looks good.

packages/page-files/src/CrustFiles.tsx
@@ -43,7 +43,7 @@ const shortStr = (name: string, count = 6): string => {
};

function createUrl (f: SaveFile) {
const endpoint = f.UpEndpoint || 'https://ipfs.io';
const endpoint = 'https://cf-ipfs.com';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we get rid of f.UpEdnpoint?

Copy link
Contributor Author

@XueMoMo XueMoMo May 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TarikGul Because currently UpEndpoint is only used for uploading files and cannot be used to access files.

@XueMoMo XueMoMo requested a review from TarikGul May 20, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TarikGul TarikGul Awaiting requested review from TarikGul

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XueMoMo @itsbirdo @TarikGul