Fix client check (#840)

polarismesh · Dec 2, 2022 · 258724a · 258724a
1 parent 0895542
commit 258724a
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 345 deletions.
diff --git a/go.sum b/go.sum
diff --git a/plugin/discoverevent/local/event_local_test.go b/plugin/discoverevent/local/event_local_test.go
@@ -19,14 +19,14 @@ package local
 
 import (
 	"context"
-	"github.com/golang/protobuf/ptypes/wrappers"
-	api "github.com/polarismesh/polaris/common/api/v1"
 	"sync"
 	"testing"
 	"time"
 
+	"github.com/golang/protobuf/ptypes/wrappers"
 	"github.com/stretchr/testify/assert"
 
+	api "github.com/polarismesh/polaris/common/api/v1"
 	"github.com/polarismesh/polaris/common/model"
 )
 

diff --git a/service/healthcheck/check.go b/service/healthcheck/check.go
@@ -372,6 +372,7 @@ func (c *CheckScheduler) checkCallbackClient(value interface{}) {
 	}
 	instanceValue.mutex.Lock()
 	defer instanceValue.mutex.Unlock()
+
 	var checkResp *plugin.CheckResponse
 	var err error
 	defer func() {

diff --git a/service/healthcheck/dispatch.go b/service/healthcheck/dispatch.go
@@ -147,7 +147,7 @@ func (d *Dispatcher) reloadManagedClients() {
 	log.Infof("[Health Check][Dispatcher]count %d clients has been dispatched to %s, total is %d",
 		len(nextClients), d.svr.localHost, d.svr.cacheProvider.healthCheckInstances.Count())
 	originClients := d.managedClients
-	d.managedClients = originClients
+	d.managedClients = nextClients
 	if len(nextClients) > 0 {
 		for id, client := range nextClients {
 			if len(originClients) == 0 {

diff --git a/store/mock/api_mock.go b/store/mock/api_mock.go
diff --git a/store/sqldb/instance.go b/store/sqldb/instance.go
@@ -907,9 +907,9 @@ func batchDeleteInstanceMeta(tx *BaseTx, instances []*model.Instance) error {
 		if entry.FirstRegis {
 			continue
 		}
-		
+
 		ids = append(ids, entry.ID())
-		
+
 		if len(ids) > 1 {
 			builder.WriteString(",")
 		}