Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Undo conflicting fix #19463

Merged
merged 1 commit into from
Oct 26, 2024
Merged

refactor: Undo conflicting fix #19463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions crates/polars-core/src/frame/group_by/perfect.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ where
per_thread_offsets.push(std::cmp::min(cache_aligned_offset, len));
}
}
*per_thread_offsets.last_mut().unwrap() = len;

let groups_ptr = unsafe { SyncPtr::new(groups.as_mut_ptr()) };
let first_ptr = unsafe { SyncPtr::new(first.as_mut_ptr()) };
Expand All @@ -76,9 +75,9 @@ where
let end = per_thread_offsets[thread_no + 1];
let end = T::Native::from_usize(end).unwrap();

if start == end {
if start == end && thread_no != n_threads - 1 {
return;
}
};

let push_to_group = |cat, row_nr| unsafe {
debug_assert!(cat < len);
Expand Down