Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Add credential_provider argument to more read functions #19421

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

nameexhaustion
Copy link
Collaborator

  • read_parquet
  • scan_csv
  • scan_ndjson
  • read_ndjson
  • scan_ipc

Was not added to read_csv and read_ipc as they use fsspec

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.04%. Comparing base (69c9c3a) to head (e819102).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
py-polars/polars/io/ipc/functions.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19421   +/-   ##
=======================================
  Coverage   80.03%   80.04%           
=======================================
  Files        1532     1532           
  Lines      210749   210779   +30     
  Branches     2442     2444    +2     
=======================================
+ Hits       168676   168712   +36     
+ Misses      41518    41511    -7     
- Partials      555      556    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review October 24, 2024 09:25
@ritchie46 ritchie46 merged commit 425e251 into pola-rs:main Oct 25, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants