Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Add var/std support to new streaming engine #19406

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Oct 23, 2024

No description provided.

@orlp orlp changed the title refactor(rust): Add var/std support to new-streaming engine refactor(rust): Add var/std support to new streaming engine Oct 23, 2024
@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 2.40964% with 243 lines in your changes missing coverage. Please review.

Project coverage is 79.96%. Comparing base (4cfe56f) to head (a6159ea).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-expr/src/reduce/var_std.rs 0.00% 102 Missing ⚠️
crates/polars-expr/src/reduce/mod.rs 0.00% 59 Missing ⚠️
crates/polars-expr/src/reduce/min_max.rs 0.00% 42 Missing ⚠️
crates/polars-expr/src/reduce/mean.rs 0.00% 26 Missing ⚠️
crates/polars-compute/src/var_cov.rs 37.50% 10 Missing ⚠️
crates/polars-expr/src/reduce/convert.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19406      +/-   ##
==========================================
- Coverage   80.04%   79.96%   -0.08%     
==========================================
  Files        1532     1533       +1     
  Lines      210713   210877     +164     
  Branches     2442     2442              
==========================================
- Hits       168658   168626      -32     
- Misses      41500    41696     +196     
  Partials      555      555              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orlp orlp merged commit 1452468 into pola-rs:main Oct 24, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant