[Supplier] Initial slashing implementation #795

red-0ne · 2024-09-04T22:08:15Z

Summary

This PR introduces the initial implementation of Supplier slashing:

Adjusts proof parameters to align with the probabilistic proofs paper.
Adds comments on potential follow-up improvements and adjustments.
Implements Supplier slashing for invalid or missing proofs.
Unstakes a Supplier whose stake falls below the minimum due to slashing.
Move the ComputeUnitsToTokenMultiplier to the shared module.

~1300LOC is auto-generated code

Issue

To enable permissionless demand, the protocol must discourage the submission of false or invalid claims.

As part of this, Suppliers should be penalized for failing to comply with the C&P life cycle rules.

[Load Testing] Permissionless Demand Implementation Umbrella Ticket #758

Type of change

Select one or more from the following:

New feature, functionality or library
Consensus breaking; add the consensus-breaking label if so. See [Infra] Automatically add the consensus-breaking label #791 for details
Bug fix
Code health or cleanup
Documentation
Other (specify)

Testing

Documentation: make docusaurus_start; only needed if you make doc changes
Unit Tests: make go_develop_and_test
LocalNet E2E Tests: make test_e2e
DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

I have tested my changes using the available tooling
I have commented my code
I have performed a self-review of my own code; both comments & source code
I create and reference any new tickets, if applicable
I have left TODOs throughout the codebase, if applicable

…oofs

Olshansk

Haven't gone through the meet yet in x/tokenomics/keeper/settle_pending_claims.go but publishing a partial review

pkg/relayer/session/claim.go

app/app_config.go

e2e/tests/0_settlement.feature

e2e/tests/session.feature

x/tokenomics/keeper/keeper_settle_pending_claims_test.go

x/tokenomics/keeper/settle_pending_claims.go

…oofs

app/app_config.go

e2e/tests/0_settlement.feature

e2e/tests/session.feature

proto/poktroll/proof/params.proto

x/tokenomics/keeper/settle_pending_claims.go

…oofs

proto/poktroll/tokenomics/event.proto

x/tokenomics/keeper/keeper_settle_pending_claims_test.go

x/tokenomics/keeper/settle_pending_claims.go

x/tokenomics/tokenomics.go

x/tokenomics/keeper/token_logic_modules.go

x/tokenomics/keeper/settle_pending_claims.go

…oofs

red-0ne · 2024-09-17T16:02:56Z

@Olshansk

I added an unexpected change due to a conflict (cyclic dependency) resulting from merging main into this branch.

The ComputeUnitsToTokenMultiplier is now moved to the shared module to resolve a conflict.

The conflict itself is due to main using ProofRequirementForClaim from the proof module.

While in this branch, ProofRequirementForClaim needs the ComputeUnitsToTokenMultiplier (from tokenomics module) to check against the ProofRequirementThreshold which results in a cyclic dependency.

Olshansk

Minor comment but LGTM otherwise!

proto/poktroll/shared/params.proto

x/proof/types/shared_query_client.go

github-actions · 2024-09-18T09:13:34Z

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 795)
Grafana network dashboard for devnet-issue-795

…oofs

…egration-app * pokt/main: [Supplier] Initial slashing implementation (#795) [Container image] Change base image for release (#829) [Proof] Prevent proof submission when not required (#822)

…ke-transfer * pokt/main: [Supplier] Initial slashing implementation (#795) [Container image] Change base image for release (#829) [Proof] Prevent proof submission when not required (#822)

…actor/transfer-msg_period-param * issues/657/feat/app-stake-transfer: [Supplier] Initial slashing implementation (#795) [Container image] Change base image for release (#829) [Proof] Prevent proof submission when not required (#822)

…ues/657/chore/app-transfer-period * issues/657/refactor/transfer-msg_period-param: [Supplier] Initial slashing implementation (#795) [Container image] Change base image for release (#829) [Proof] Prevent proof submission when not required (#822) # Conflicts: # app/app_config.go

…nt-stake-supplier * pokt/main: [Supplier] Initial slashing implementation (#795)

…99/e2e/param-helpers * issues/799/e2e/idempotent-stake-supplier: chore: add comment chore: sync shared module default params fix: failing E2E test [Supplier] Initial slashing implementation (#795) [Container image] Change base image for release (#829) [Proof] Prevent proof submission when not required (#822) chore: rename paramsAnyMap type to mitigate variable name shadowing [Tooling, Code Health] refactor: split Makefile into multiple files (#816) [Tooling] fix and add makefile targets (#814) [Docs] Add a debugging tip: using transaction hashes (#786)

…lier-stake-events * issues/799/e2e/param-helpers: chore: review feedback improvements chore: add comment chore: sync shared module default params fix: failing E2E test [Supplier] Initial slashing implementation (#795) [Container image] Change base image for release (#829) [Proof] Prevent proof submission when not required (#822) chore: rename paramsAnyMap type to mitigate variable name shadowing [Tooling, Code Health] refactor: split Makefile into multiple files (#816) [Tooling] fix and add makefile targets (#814) [Docs] Add a debugging tip: using transaction hashes (#786)

…tests/params * issues/799/feat/supplier-stake-events: chore: review feedback improvements chore: add comment chore: sync shared module default params fix: failing E2E test [Supplier] Initial slashing implementation (#795) [Container image] Change base image for release (#829) [Proof] Prevent proof submission when not required (#822) chore: rename paramsAnyMap type to mitigate variable name shadowing [Tooling, Code Health] refactor: split Makefile into multiple files (#816) [Tooling] fix and add makefile targets (#814) [Docs] Add a debugging tip: using transaction hashes (#786)

## Summary This PR introduces the initial implementation of `Supplier` slashing: - Adjusts proof parameters to align with the probabilistic proofs paper. - Adds comments on potential follow-up improvements and adjustments. - Implements `Supplier` slashing for invalid or missing proofs. - Unstakes a `Supplier` whose stake falls below the minimum due to slashing. - Move the `ComputeUnitsToTokenMultiplier` to the `shared` module. _~1300LOC is auto-generated code_ ## Issue To enable permissionless demand, the protocol must discourage the submission of false or invalid claims. As part of this, `Suppliers` should be penalized for failing to comply with the C&P life cycle rules. - #758 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [x] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [x] **Unit Tests**: `make go_develop_and_test` - [x] **LocalNet E2E Tests**: `make test_e2e` - [x] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [x] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Daniel Olshansky <[email protected]>

feat: Initial slashing implementation

c9f2aac

red-0ne added supplier Changes related to the Supplier actor on-chain On-chain business logic tokenomics Token Economics - what else do you need? labels Sep 4, 2024

red-0ne requested review from bryanchriswhite and Olshansk September 4, 2024 22:08

red-0ne self-assigned this Sep 4, 2024

Merge branch 'main' into feat/slash-missing-proofs

ac4ea35

Olshansk added this to the Shannon Beta TestNet Launch milestone Sep 9, 2024

red-0ne added 2 commits September 10, 2024 16:25

Merge remote-tracking branch 'origin/main' into feat/slash-missing-pr…

3a6509a

…oofs

fix: Use claimed amount in place of compute units

6ae5856

Olshansk requested changes Sep 11, 2024

View reviewed changes

red-0ne added 6 commits September 11, 2024 06:17

Merge remote-tracking branch 'origin/main' into feat/slash-missing-pr…

5e56120

…oofs

refactor: Proof requirement threshold as coin

b9d032b

feat: Add supplier slashing event

3a298d6

Merge remote-tracking branch 'origin/main' into feat/slash-missing-pr…

3cc8107

…oofs

fix: Unused function and err shadow declaration

4851c2d

chore: Revert test table length

a6c1678

red-0ne requested a review from Olshansk September 11, 2024 12:30

fix: Remove wrong comment

efdd002

red-0ne added the consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. label Sep 12, 2024

red-0ne mentioned this pull request Sep 12, 2024

[Load Testing] Permissionless Demand Implementation Umbrella Ticket #758

Open

23 tasks

Olshansk requested changes Sep 13, 2024

View reviewed changes

red-0ne added 3 commits September 16, 2024 11:34

chore: Address reivew change requests

1672e4d

Merge remote-tracking branch 'origin/main' into feat/slash-missing-pr…

b92cb4c

…oofs

refactor: Move NumComputeUnitsToCoin to tokenomcis package

182e06a

red-0ne mentioned this pull request Sep 16, 2024

[Proof] Prevent proof submission when not required #822

Merged

15 tasks

red-0ne requested a review from Olshansk September 16, 2024 11:09

Olshansk requested changes Sep 16, 2024

View reviewed changes

chore: Address review change requests

e088543

chore: Update autogenerated code

34fbaf2

red-0ne requested a review from Olshansk September 17, 2024 08:27

red-0ne added 2 commits September 17, 2024 16:54

refactor: Move compute units to token multiplier to shared module

6dd7c22

Merge remote-tracking branch 'origin/main' into feat/slash-missing-pr…

afa3808

…oofs

chore: Remove unused function

5fc6fff

Olshansk approved these changes Sep 17, 2024

View reviewed changes

proto/poktroll/shared/params.proto Show resolved Hide resolved

x/proof/types/shared_query_client.go Outdated Show resolved Hide resolved

red-0ne added the devnet-test-e2e label Sep 18, 2024

github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Sep 18, 2024

red-0ne added 2 commits September 18, 2024 14:30

Merge remote-tracking branch 'origin/main' into feat/slash-missing-pr…

c521772

…oofs

chore: Address review change requests

baea519

red-0ne merged commit 09fc4ce into main Sep 18, 2024
10 checks passed

bryanchriswhite added a commit that referenced this pull request Sep 19, 2024

Merge remote-tracking branch 'pokt/main' into issues/799/e2e/idempote…

2f1af15

…nt-stake-supplier * pokt/main: [Supplier] Initial slashing implementation (#795)

bryanchriswhite mentioned this pull request Oct 11, 2024

[Utility] Minimum staking values for each actor #612

Closed

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Supplier] Initial slashing implementation #795

[Supplier] Initial slashing implementation #795

red-0ne commented Sep 4, 2024 •

edited

Loading

Olshansk left a comment

red-0ne commented Sep 17, 2024

Olshansk left a comment

github-actions bot commented Sep 18, 2024

[Supplier] Initial slashing implementation #795

[Supplier] Initial slashing implementation #795

Conversation

red-0ne commented Sep 4, 2024 • edited Loading

Summary

Issue

Type of change

Testing

Sanity Checklist

Olshansk left a comment

Choose a reason for hiding this comment

red-0ne commented Sep 17, 2024

Olshansk left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 18, 2024

red-0ne commented Sep 4, 2024 •

edited

Loading