Feat/payable proof submission #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
Olshansk
approved these changes
Sep 4, 2024
| // an adjustment the current balance to account for the proof submission fee | ||
| // is needed so validateAmountChange can assert on the reward change with the | ||
| // given condition. | ||
| if msgType == "SubmitProof" { |
There was a problem hiding this comment.
I see what you're doing here, but this is a "hidden side effect".
I think you should just either:
- Add a step call
EnsureBalanceIsHighEnoughForProofSubmission
OR - Update the default configs of LocalNet to give everyone high enough balances that this doesn't matter
My preference is (2).
There was a problem hiding this comment.
This is actually not about having enough funds.
It is to make the step Then the account balance of "supplier1" should be "420" uPOKT "more" than before succeed without making it more complicated
fee > reward->lower balanceproof not required->no fee- step needing to know about previous ones
- ...
There's actually an elegant solution without side effect.
Take a snapshot of the balance after the proof submission.
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 780) |
red-0ne
changed the base branch from
feat/proof-submission-fee-param
to
main
bryanchriswhite
added a commit
that referenced
this pull request
Sep 9, 2024
…eriod-param' into issues/657/chore/app-transfer-period * pokt/issues/657/refactor/transfer-msg_period-param: chore: review feedback improvements Feat/payable proof submission (#780) [Proof] Proof submission fee param (#779) [Service] Align add service fee param with other params implementation (#778) [Docs] how to create a new release (#783) [Dependencies] Bump go and cosmos-sdk (#797) [Small PR][CI] Add check for stable marshalers (#784)
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Summary This PR implements payable proof submission given the proof submission governance param. This is a follow-up feature PR to #779 which adds the proof submission governance param. ## Issue Proof messages take up significant block space. We need to deter submitting non-required ones by making proof submission payable by a governance adjusted parameter. - #758 ## Type of change Select one or more: - [x] New feature, functionality or library - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [x] **Unit Tests**: `make go_develop_and_test` - [x] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [x] I have left TODOs throughout the codebase, if applicable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements payable proof submission given the proof submission governance param.
This is a follow-up feature PR to #779 which adds the proof submission governance param.
Issue
Proof messages take up significant block space. We need to deter submitting non-required ones by making proof submission payable by a governance adjusted parameter.
Type of change
Select one or more:
Testing
make docusaurus_start; only needed if you make doc changesmake go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR.Sanity Checklist