[NOT MERGE BEFORE #26] Add supply indexing #28
+194
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new `Supply` type in `schema.graphql`. - Created `getSupply` function in `src/mappings/bank/supply.ts` to fetch total supply. - Modified `handleGenesis` to store the initial supply from genesis state. - Added `_handleSupply` function in `src/mappings/primitives.ts` to periodically index total supply. - Updated the Genesis interface to include supply data.
- Introduced `supplies` field in `Block` type to reference `Supply` entities. - Added new fields `denom` and `block` to `Supply` type. - Replaced `getSupply` with `queryTotalSupply` and implement `getSupplyRecord`. - Modified `_handleSupply` to create supply records with `getSupplyRecord` and avoid duplicates.
jorgecuesta
changed the title
jorgecuesta
changed the title
bryanchriswhite
requested changes
Nov 13, 2024
- Removed `_handleSupply` from `primitives.ts` and imported it from `supply.ts`. - Reorganized `getSupplyRecord` in `supply.ts` to use `getSupplyId` for ID generation. - Simplified supply concatenation logic in `queryTotalSupply` by using `push` instead of `concat`. - Centralized total supply handling in `supply.ts` for clearer separation of concerns.
bryanchriswhite
approved these changes
Nov 13, 2024
…what we plan to do on future releases.
- Introduced new handler `handleBlockSupply` to link block with recent supply. - Added `supply` field to `Block` entity in GraphQL schema. - Ensured supply records in genesis block are handled properly. - Modified `_handleSupply` and `_handleBlockSupply` to update and retrieve supply data. - Updated `Genesis` interface to include supply information.
…the amount changes.
- Replaced the old block supply handler with a more robust tracking system. - Introduced `SupplyDenom` and `BlockSupply` entities for better denomination supply tracking. - Added logic to handle supply records creation for each block, adjusting for the genesis block. - Adjusted schema to accommodate new entities and relationships. - Removed unused functions and refactored supply-related code for clarity and efficiency.
|
@bryanchriswhite Please refer to the attached images to look how the structure looks at the database and also the same result on the graphql query. I think now this achieve a proper handling of supply for any denomination on the block, which allows further updates on the protocol like IBC transactions without need to modify it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the Supply entity and updates the block entity.
Issue
This PR addresses improvements required for supply handling and indexing. The updates include:
Type of change
Select one or more:
Sanity Checklist