Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restore origin gocuke and update #970

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Aug 7, 2023

Description

Summary generated by Reviewpad on 07 Aug 23 07:42 UTC

This pull request updates the dependencies in the go.mod file and the go.sum file. It restores the origin gocuke dependency and updates it to version 0.6.3.

Issue

N/A (techdebt)

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Remove replace directive in go.mod for gocuke dependency
  • Update gocuke dependency to v0.6.3 (latest release; includes our fork's changes)

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@bryanchriswhite bryanchriswhite added code health Nice to have code improvement tooling tooling to support development, testing et al push-image Build and push a container image on non-main builds e2e-devnet-test Runs E2E tests on devnet labels Aug 7, 2023
@bryanchriswhite bryanchriswhite self-assigned this Aug 7, 2023
@reviewpad reviewpad bot added the small Pull request is small label Aug 7, 2023
@bryanchriswhite bryanchriswhite marked this pull request as ready for review August 7, 2023 08:09
Comment on lines -8 to -10
// TECHDEBT: remove once upstream PR is merged (see: https://github.com/regen-network/gocuke/pull/12)
replace github.com/regen-network/gocuke => github.com/pokt-network/gocuke v0.0.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Contributor

@dylanlott dylanlott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bryanchriswhite bryanchriswhite merged commit afc873e into main Aug 8, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Nice to have code improvement e2e-devnet-test Runs E2E tests on devnet push-image Build and push a container image on non-main builds small Pull request is small tooling tooling to support development, testing et al waiting-for-review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants