[LocalNet] Fix metrics scraping #940
Merged
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olshansk
approved these changes
Aug 1, 2023
red-0ne
pushed a commit
that referenced
this pull request
Aug 2, 2023
## Description Fixes metrics scraping on LocalNet. After quite a few changes to the LocalNet infrastructure, the metrics collection appeared broken on LocalNet. <!-- reviewpad:summarize:start --> ### Summary generated by Reviewpad on 26 Jul 23 21:58 UTC This pull request fixes the issue with metrics scraping on LocalNet. It updates the Tiltfile and statefulset.yaml files to add pod annotations for Prometheus scraping and specify the port for scraping. <!-- reviewpad:summarize:end --> ## List of changes - Changed `podAnnotations` helm chart value to always "quote" values in case they are not strings (K8s API expects strings only in annotations) - Added annotations necessary for scraping of exporter endpoints by Prometheus on LocalNet
dylanlott
pushed a commit
that referenced
this pull request
Aug 7, 2023
## Description Fixes metrics scraping on LocalNet. After quite a few changes to the LocalNet infrastructure, the metrics collection appeared broken on LocalNet. <!-- reviewpad:summarize:start --> ### Summary generated by Reviewpad on 26 Jul 23 21:58 UTC This pull request fixes the issue with metrics scraping on LocalNet. It updates the Tiltfile and statefulset.yaml files to add pod annotations for Prometheus scraping and specify the port for scraping. <!-- reviewpad:summarize:end --> ## List of changes - Changed `podAnnotations` helm chart value to always "quote" values in case they are not strings (K8s API expects strings only in annotations) - Added annotations necessary for scraping of exporter endpoints by Prometheus on LocalNet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes metrics scraping on LocalNet.
After quite a few changes to the LocalNet infrastructure, the metrics collection appeared broken on LocalNet.
Summary generated by Reviewpad on 26 Jul 23 21:58 UTC
This pull request fixes the issue with metrics scraping on LocalNet. It updates the Tiltfile and statefulset.yaml files to add pod annotations for Prometheus scraping and specify the port for scraping.
List of changes
podAnnotationshelm chart value to always "quote" values in case they are not strings (K8s API expects strings only in annotations)