Sendable support #30
Sendable support #30
Conversation
Sources/Gen/Gen.swift
Outdated
| @@ -13,6 +13,7 @@ public struct Gen<Value> { | |||
| /// - Parameter rng: A random number generator. | |||
| /// - Returns: A random value. | |||
| @inlinable | |||
| @Sendable | |||
There was a problem hiding this comment.
I think this can be removed. Do you have a situation in which it's required?
| @Sendable |
There was a problem hiding this comment.
That’s good feedback. I didn’t include those annotations at first, but the compiler highlighted an issue with composability of the methods. I’m on vacation at the moment so I don’t have my mac in front of me, but I remember there were a couple of times in the library code where a function was passed as a parameter and needed to be Sendable. Looks like ‘shuffled’ was one of them. Rather than just annotate a couple methods I included the annotation on all similar methods. I could change those cases to use an explicit closure and call the method from inside the body if you prefer. I just didn’t see a downside to including the annotation, especially since it was used in the library itself.
There was a problem hiding this comment.
@seanmrich I think those instances could potentially be refactored, but it'd help if you could share whenever you're back, no rush 😄
Sources/Gen/Gen.swift
Outdated
| @@ -27,6 +28,7 @@ public struct Gen<Value> { | |||
| /// | |||
| /// - Returns: A random value. | |||
| @inlinable | |||
| @Sendable | |||
There was a problem hiding this comment.
This too.
| @Sendable |
Sources/Gen/Gen.swift
Outdated
| @@ -39,6 +41,7 @@ extension Gen { | |||
| /// - Parameter value: A constant value. | |||
| /// - Returns: A generator of a constant value. | |||
| @inlinable | |||
| @Sendable | |||
Sources/Gen/Gen.swift
Outdated
| @@ -48,31 +51,24 @@ extension Gen { | |||
| /// - Parameter transform: A function that transforms `Value`s into `NewValue`s. | |||
| /// - Returns: A generator of `NewValue`s. | |||
| @inlinable | |||
| public func map<NewValue>(_ transform: @escaping (Value) -> NewValue) -> Gen<NewValue> { | |||
| @Sendable | |||
Sources/Gen/Gen.swift
Outdated
| extension Gen { | ||
| /// Transforms a generator of `Value`s into a generator of `NewValue`s by transforming a value into a generator of `NewValue`s. | ||
| /// | ||
| /// - Parameter transform: A function that transforms `Value`s into a generator of `NewValue`s. | ||
| /// - Returns: A generator of `NewValue`s. | ||
| @inlinable | ||
| public func flatMap<NewValue>(_ transform: @escaping (Value) -> Gen<NewValue>) -> Gen<NewValue> { | ||
| @Sendable |
|
Hopefully this commit meets the spirit of what you were looking for. |
|
Sorry about the CI failures. I have to admit I've got little experience with workflows so I had to read up on it. Should be good to go now. |
Genmodified to beSendable.