pnp · ferrarirosso · Oct 31, 2024
diff --git a/samples/react-rss-reader/.devcontainer/devcontainer.json b/samples/react-rss-reader/.devcontainer/devcontainer.json
@@ -1,7 +1,7 @@
 // For more information on how to run this SPFx project in a VS Code Remote Container, please visit https://aka.ms/spfx-devcontainer
 {
-	"name": "SPFx 1.18.2",
-	"image": "docker.io/m365pnp/spfx:1.18.2",
+	"name": "SPFx 1.20.0",
+	"image": "docker.io/m365pnp/spfx:1.20.0",
 	// Set *default* container specific settings.json values on container create.
 	"settings": {},
 	// Add the IDs of extensions you want installed when the container is created.

diff --git a/samples/react-rss-reader/.eslintrc.js b/samples/react-rss-reader/.eslintrc.js
diff --git a/samples/react-rss-reader/.nvmrc b/samples/react-rss-reader/.nvmrc
@@ -1 +1 @@
-v18.18.0
+v18.20.4
diff --git a/samples/react-rss-reader/.yo-rc.json b/samples/react-rss-reader/.yo-rc.json
@@ -2,15 +2,15 @@
   "@microsoft/generator-sharepoint": {
     "isCreatingSolution": true,
     "environment": "spo",
-    "version": "1.18.2",
+    "version": "1.20.0",
     "libraryName": "react-rssreader",
     "libraryId": "fcb53167-e0d5-4ed1-9648-149146649aa1",
     "packageManager": "npm",
     "isDomainIsolated": false,
     "componentType": "webpart",
     "nodeVersion": "18.17.1",
     "sdkVersions": {
-      "@microsoft/teams-js": "2.12.0",
+      "@microsoft/teams-js": "2.24.0",
       "@microsoft/microsoft-graph-client": "3.0.2"
     }
   }

diff --git a/samples/react-rss-reader/README.md b/samples/react-rss-reader/README.md
@@ -4,7 +4,7 @@
 
 A RSS Reader original based [on work by Olivier Carpentier](https://github.com/OlivierCC/spfx-40-fantastics/tree/master/src/webparts/rssReader), part of the [SPFx Fantastic 40 Web Parts](https://github.com/OlivierCC/spfx-40-fantastics)
 
-This RSS Reader utilizes SharePoint Framework v1.18.2 with no dependency on jQuery or a RSS Feed library. This project does utilize [ 
+This RSS Reader utilizes SharePoint Framework v1.20.0 with no dependency on jQuery or a RSS Feed library. This project does utilize [ 
 @pnp/spfx-property-controls](https://sharepoint.github.io/sp-dev-fx-property-controls/), and Moment React for date manipulation. Handlebar template option derived from React Search Refiners ([PnP Modern Search](https://microsoft-search.github.io/pnp-modern-search/)). Use NodeJS version 18 (validated using v18.17.1) to compile or rebuild the SPFx solution.
 
 Main features include:
@@ -27,7 +27,7 @@ Main features include:
 | Every SPFx version is only compatible with specific version(s) of Node.js. In order to be able to build this sample, please ensure that the version of Node on your workstation matches one of the versions listed in this section. This sample will not work on a different version of Node.|
 |Refer to <https://aka.ms/spfx-matrix> for more information on SPFx compatibility.   |
 
-![SPFx 1.18.2](https://img.shields.io/badge/SPFx-1.18.2-green.svg)
+![SPFx 1.20](https://img.shields.io/badge/SPFx-1.20.0-green.svg)
 ![Node.js v18](https://img.shields.io/badge/Node.js-v18-green.svg)
 ![Compatible with SharePoint Online](https://img.shields.io/badge/SharePoint%20Online-Compatible-green.svg)
 ![Does not work with SharePoint 2019](https://img.shields.io/badge/SharePoint%20Server%202019-Incompatible-red.svg "SharePoint Server 2019 requires SPFx 1.4.1 or lower")
@@ -36,7 +36,7 @@ Main features include:
 ![Hosted Workbench Compatible](https://img.shields.io/badge/Hosted%20Workbench-Compatible-green.svg)
 ![Compatible with Remote Containers](https://img.shields.io/badge/Remote%20Containers-Compatible-green.svg)
 
-Tested with: Node.js v18.17.1
+Tested with: Node.js v18.20.4
 
 ## Applies to
 
@@ -60,6 +60,7 @@ Version|Date|Comments
 1.0.3 | April 21, 2023 | Added theme awareness
 1.0.4 | May 25, 2023 | Fixed direct request issues
 1.1.0 | February 6, 2024 | Upgraded to SPFx 1.18.2
+1.2.0 | October 30, 2024 | Upgraded to SPFx 1.20.0
 
 ## Minimal Path to Awesome
 

diff --git a/samples/react-rss-reader/assets/sample.json b/samples/react-rss-reader/assets/sample.json
@@ -9,7 +9,7 @@
       "A RSS Reader original based on work completed by Olivier Carpentier\u0027s"
     ],
     "creationDateTime": "2020-11-22",
-    "updateDateTime": "2023-08-18",
+    "updateDateTime": "2024-10-30",
     "products": [
       "SharePoint"
     ],
@@ -20,7 +20,7 @@
       },
       {
         "key": "SPFX-VERSION",
-        "value": "1.18.2"
+        "value": "1.20.0"
       }
     ],
     "thumbnails": [

diff --git a/samples/react-rss-reader/gulpfile.js b/samples/react-rss-reader/gulpfile.js
@@ -16,21 +16,22 @@ build.addSuppression(`Warning - [sass] The local CSS class 'ms-Grid' is not came
  ********************************************************************************************/
 build.configureWebpack.mergeConfig({
   additionalConfiguration: (generatedConfiguration) => {
-    generatedConfiguration.resolve.alias = { handlebars: 'handlebars/dist/handlebars.min.js' };
-
-    generatedConfiguration.module.rules.push(
-      {
-        test: /utils\.js$/,
-        loader: 'unlazy-loader',
-        include: [
-            /node_modules/,
-        ]
-      }
-    );
-
-    generatedConfiguration.node = {
-      fs: 'empty'
-    }
+    generatedConfiguration.resolve.fallback = {
+      fs: false, // Use "false" as fs cannot be polyfilled for browser environments
+      stream: require.resolve('stream-browserify'),
+      timers: require.resolve('timers-browserify'),
+      readline: false 
+    };
+
+    generatedConfiguration.resolve.alias = {
+      handlebars: 'handlebars/dist/handlebars.min.js'
+    };
+
+    generatedConfiguration.module.rules.push({
+      test: /utils\.js$/,
+      loader: 'unlazy-loader',
+      include: [/node_modules/]
+    });
 
     const lastDirName = path.basename(__dirname);
     const dropPath = path.join(__dirname, 'temp', 'stats');
@@ -47,6 +48,8 @@ build.configureWebpack.mergeConfig({
   }
 });
 
+
+
 var getTasks = build.rig.getTasks;
 build.rig.getTasks = function () {
   var result = getTasks.call(build.rig);

diff --git a/samples/react-rss-reader/package.json b/samples/react-rss-reader/package.json
@@ -1,12 +1,9 @@
 {
   "name": "react-rssreader",
-  "version": "1.1.0",
+  "version": "1.2.0",
   "private": true,
   "engines": {
-    "node": "18.17.1"
-  },
-  "resolutions": {
-    "@types/react": "16.8.8"
+    "node": ">=18.17.1 <19.0.0"
   },
   "main": "lib/index.js",
   "scripts": {
@@ -16,44 +13,49 @@
   },
   "dependencies": {
     "@fluentui/react": "8.106.4",
-    "@microsoft/sp-core-library": "1.18.2",
-    "@microsoft/sp-lodash-subset": "1.18.2",
-    "@microsoft/sp-office-ui-fabric-core": "1.18.2",
-    "@microsoft/sp-property-pane": "1.18.2",
-    "@microsoft/sp-webpart-base": "1.18.2",
-    "@pnp/logging": "3.22.0",
-    "@pnp/spfx-controls-react": "^3.17.0",
-    "@pnp/spfx-property-controls": "3.16.0",
-    "@types/handlebars": "4.0.39",
+    "@microsoft/sp-adaptive-card-extension-base": "1.20.0",
+    "@microsoft/sp-core-library": "1.20.0",
+    "@microsoft/sp-lodash-subset": "1.20.0",
+    "@microsoft/sp-office-ui-fabric-core": "1.20.0",
+    "@microsoft/sp-property-pane": "1.20.0",
+    "@microsoft/sp-webpart-base": "1.20.0",
+    "@pnp/logging": "4.6.0",
+    "@pnp/spfx-controls-react": "3.19.0",
+    "@pnp/spfx-property-controls": "3.18.0",
     "ace-builds": "1.32.5",
     "common-tags": "1.8.0",
-    "handlebars": "4.7.7",
-    "handlebars-helpers": "^0.8.4",
+    "handlebars": "4.7.8",
     "moment": "2.29.0",
     "react": "17.0.1",
     "react-ace": "10.1.0",
     "react-dom": "17.0.1",
     "react-moment": "1.1.3",
     "ts-md5": "1.2.4",
     "tslib": "2.3.1",
+    "util": "^0.12.5",
     "xml2js": "0.4.19"
   },
   "devDependencies": {
-    "@microsoft/eslint-config-spfx": "1.18.2",
-    "@microsoft/eslint-plugin-spfx": "1.18.2",
+    "@microsoft/eslint-config-spfx": "1.20.2",
+    "@microsoft/eslint-plugin-spfx": "1.20.2",
     "@microsoft/rush-stack-compiler-4.7": "0.1.0",
-    "@microsoft/sp-build-web": "1.18.2",
-    "@microsoft/sp-module-interfaces": "1.18.2",
-    "@rushstack/eslint-config": "2.5.1",
+    "@microsoft/sp-build-web": "1.20.2",
+    "@microsoft/sp-module-interfaces": "1.20.2",
+    "@rushstack/eslint-config": "4.0.1",
     "@types/react": "17.0.45",
     "@types/react-dom": "17.0.17",
     "@types/webpack-env": "1.15.2",
+    "@typescript-eslint/eslint-plugin": "^8.12.2",
+    "@typescript-eslint/parser": "^8.12.2",
     "ajv": "6.12.5",
-    "eslint": "8.7.0",
+    "eslint": "8.57.0",
     "eslint-plugin-react-hooks": "4.3.0",
     "gulp": "4.0.2",
+    "stream-browserify": "^3.0.0",
+    "timers-browserify": "^2.0.12",
     "typescript": "4.7.4",
     "unlazy-loader": "0.1.3",
-    "webpack-bundle-analyzer": "^3.0.3"
+    "url": "^0.11.4",
+    "webpack-bundle-analyzer": "^4.10.2"
   }
 }