Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to SPFx 1.20 #5243 #5310

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Upgrade to SPFx 1.20 #5243 #5310

merged 3 commits into from
Oct 21, 2024

Conversation

ferrarirosso
Copy link

By submitting this pull request, you agree to the contribution guidelines

If you aren't familiar with how to contribute to open-source repositories using GitHub, or if you find the instructions on this page confusing, sign up for one of our Sharing is Caring events. It's completely free, and we'll guide you through the process.

To submit a pull request with multiple authors, make sure that at least one commit is a co-authored commit by adding a Co-authored-by: trailer to the commit's message. E.g.: Co-authored-by: name <[email protected]>

Put an x in all the items that apply ([x], no spaces between the [, the x, and the ] ), make notes next to any that haven't been addressed.

What's in this Pull Request?

SPFx Upgrade to 1.20.0
Refactor SPSecurity.tsx React functional component
Remove unused code
Minor bug fixes in layout

Node Version

18.20.4

Node version used:

Checklist

This checklist is used to automatically pre-process your pull request; It is meant to help process pull requests in a timely manner, rather than hoops to jump through.

Put an x in all the items that apply ([x], no spaces between the [, the x, and the ] ). Make notes next to any that haven't been addressed.

  • My pull request affects only ONE sample.
  • My sample builds without any warnings
  • I have updated the README.md file's Version history. For new samples, created a new README.md file matching this template
  • My README.md has at least one static high-resolution screenshot (i.e. not a GIF) located in the assets folder.
  • My README.md contains complete setup instructions, including pre-requisites and permissions required
  • My solution includes a .nvmrc file indicating the version of Node.js

@Adam-it Adam-it self-assigned this Oct 21, 2024
@hugoabernier hugoabernier merged commit ae22ff6 into pnp:main Oct 21, 2024
2 checks passed
@hugoabernier
Copy link
Collaborator

Thanks @ferrarirosso for your update! Highly appreciated!.

Thank you for sharing your sample with others - you rock! 👏🥇👩‍💻

@ferrarirosso
Copy link
Author

Thanks @hugoabernier you're welcome 🙏

@ferrarirosso ferrarirosso deleted the issue-5243 branch October 21, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Security Grid web part to latest version of SPFx - Refresh Rangers Hacktoberfest Event
3 participants