Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image editor webpart enhancements #5278

Merged

Conversation

ishaisagi-hns
Copy link
Contributor

  • New sample
  • Bug fix/update
  • Related issues: fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

  • Changed web part name,
  • added alt text to image in properties,
  • added properties to show\hide edit icon when page is not in edit mode, set default to off
  • added properties that hide\show the title , set default to off
  • made aspect lock on by default in both crop and resize

Node Version

Node version used:
v8.17.0

Checklist

  • [X ] My pull request affects only ONE sample.
  • My sample builds without any warnings (some wardnings that are not related to the changes I introduced)
  • [X ] I have updated the README.md file's Version history. For new samples, created a new README.md file matching this template
  • My README.md has at least one static high-resolution screenshot (i.e. not a GIF) located in the assets folder.
  • My README.md contains complete setup instructions, including pre-requisites and permissions required
  • My solution includes a .nvmrc file indicating the version of Node.js

ishaisagi-hns and others added 4 commits September 9, 2024 13:38
…essibility changes, show url in property pane
…roperties to show\hide edit icon, made the title off and icon off by default, made aspect lock on by default
@hugoabernier
Copy link
Collaborator

@petkir I'm unable to build this sample. Are you able to build it from a clean install?

@ishaisagi-hns
Copy link
Contributor Author

ishaisagi-hns commented Oct 12, 2024 via email

@petkir
Copy link
Contributor

petkir commented Oct 12, 2024

@hugoabernier wrong address :-) i have fun with calendar-feed WP Webpack Cors libs they are some years old :-) but I will check it give me some minutes

@petkir
Copy link
Contributor

petkir commented Oct 12, 2024

@ishaisagi-hns
nice enhancement
lockAspectCrop: true,
lockAspectResize: true

image

@hugoabernier it's working
only node 8 i had to install and gulp steps are below

steps:

nvm install v8
nvm use v8
npm install
npm i [email protected] -DE 
npx gulp trust-dev-cert
npx gulp serve  

cool thing i learned, a pr can be fetched also as no maintainer :-)

 git fetch origin pull/5278/head:testreactimageeditorpr

@hugoabernier hugoabernier merged commit 8831065 into pnp:main Oct 13, 2024
2 checks passed
@hugoabernier
Copy link
Collaborator

Thanks @ishaisagi-hns for your update! Always appreciated!.

Thank you for sharing your sample with others - you rock! 👏🥇👩‍💻

@PopWarner
Copy link
Member

🎉✨ Woohoo! ✨🎉

Thank you @ishaisagi-hns for your awesome contribution to the community with this merged PR! 🚀 You've earned a Credly badge through the Microsoft 365 & Power Platform Recognition Program. 🏅 To receive your badge, please take a moment to opt in to the program. You can learn more and sign up here: https://aka.ms/community/recognition.

Can't wait to see you in the program! 🎊

Cheers,
David Warner 🧡💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants