-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image editor webpart enhancements #5278
Image editor webpart enhancements #5278
Conversation
…essibility changes, show url in property pane
…roperties to show\hide edit icon, made the title off and icon off by default, made aspect lock on by default
@petkir I'm unable to build this sample. Are you able to build it from a clean install? |
Hugo, make sure you are on node v8. I'll post tomorrow the gulp version. I had issues setting it up initially.
Sent from Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Hugo Bernier ***@***.***>
Sent: Sunday, October 13, 2024 6:49:38 AM
To: pnp/sp-dev-fx-webparts ***@***.***>
Cc: Ishai Sagi ***@***.***>; Author ***@***.***>
Subject: Re: [pnp/sp-dev-fx-webparts] Image editor webpart enhancements (PR #5278)
@petkir<https://github.com/petkir> I'm unable to build this sample. Are you able to build it from a clean install?
—
Reply to this email directly, view it on GitHub<#5278 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BKP4WQA54KNGKGL7G576JGLZ3F4NFAVCNFSM6AAAAABPI4R4HKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGY4DENJVG4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
@hugoabernier wrong address :-) i have fun with calendar-feed WP Webpack Cors libs they are some years old :-) but I will check it give me some minutes |
@ishaisagi-hns @hugoabernier it's working steps:
cool thing i learned, a pr can be fetched also as no maintainer :-)
|
Thanks @ishaisagi-hns for your update! Always appreciated!. Thank you for sharing your sample with others - you rock! 👏🥇👩💻 |
🎉✨ Woohoo! ✨🎉 Thank you @ishaisagi-hns for your awesome contribution to the community with this merged PR! 🚀 You've earned a Credly badge through the Microsoft 365 & Power Platform Recognition Program. 🏅 To receive your badge, please take a moment to opt in to the program. You can learn more and sign up here: https://aka.ms/community/recognition. Can't wait to see you in the program! 🎊 Cheers, |
What's in this Pull Request?
Node Version
Node version used:
v8.17.0
Checklist
README.md
file's Version history. For new samples, created a newREADME.md
file matching this templateREADME.md
has at least one static high-resolution screenshot (i.e. not a GIF) located in theassets
folder.README.md
contains complete setup instructions, including pre-requisites and permissions required.nvmrc
file indicating the version of Node.js