Updated node version to node 18

pnp · Oct 23, 2024 · 0601b5e · 0601b5e
1 parent faa5d96
commit 0601b5e
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/samples/react-datatable/.devcontainer/devcontainer.json b/samples/react-datatable/.devcontainer/devcontainer.json
@@ -1,7 +1,7 @@
 // For more information on how to run this SPFx project in a VS Code Remote Container, please visit https://aka.ms/spfx-devcontainer
 {
-	"name": "SPFx 1.14.0",
-	"image": "docker.io/m365pnp/spfx:1.14.0",
+	"name": "SPFx 1.20.0",
+	"image": "docker.io/m365pnp/spfx:1.20.0",
 	// Set *default* container specific settings.json values on container create.
 	"settings": {},
 	// Add the IDs of extensions you want installed when the container is created.

diff --git a/samples/react-datatable/.nvmrc b/samples/react-datatable/.nvmrc
@@ -1 +1 @@
-20.16.0
+18.19.1
diff --git a/samples/react-datatable/.yo-rc.json b/samples/react-datatable/.yo-rc.json
@@ -1,7 +1,7 @@
 {
     "@microsoft/generator-sharepoint": {
       "@microsoft/generator-sharepoint": {
-        "nodeVersion": "20.16.0"
+        "nodeVersion": "18.19.1"
       },
       "sdksVersions": {
         "@microsoft/microsoft-graph-client": "3.0.2",

diff --git a/samples/react-datatable/assets/sample.json b/samples/react-datatable/assets/sample.json
@@ -9,7 +9,7 @@
       "This web part provides easy way to render SharePoint custom list in data table view with all the necessary features."
     ],
     "creationDateTime": "2021-03-01",
-    "updateDateTime": "2022-11-01",
+    "updateDateTime": "2024-10-20",
     "products": [
       "SharePoint"
     ],
@@ -20,7 +20,7 @@
       },
       {
         "key": "SPFX-VERSION",
-        "value": "1.14.0"
+        "value": "1.20.0"
       },
       {
         "key": "PNPCONTROLS",

diff --git a/samples/react-datatable/package.json b/samples/react-datatable/package.json
@@ -3,7 +3,7 @@
   "version": "1.6.0",
   "private": true,
   "engines": {
-    "node": ">=18.17.1 <19.0.0"
+    "node": ">=16.13.0 <17.0.0 || >=18.17.1 <19.0.0"
   },
   "main": "lib/index.js",
   "scripts": {