Fix issues and update news ticker SPFX version

samples/react-application-news-ticker/.gitignore

@@ -13,6 +13,7 @@ release
 solution
 temp
 *.sppkg
+.heft
 
 # Coverage directory used by tools like istanbul
 coverage

samples/react-application-news-ticker/.yo-rc.json

@@ -2,9 +2,9 @@
   "@microsoft/generator-sharepoint": {
     "plusBeta": false,
     "isCreatingSolution": true,
-    "version": "1.14.0",
+    "version": "1.15.2",
     "libraryName": "react-application-news-ticker",
-    "libraryId": "b5d9ad1f-5198-4647-a5b6-5dbc17bf1608",
+    "libraryId": "bae26017-8238-4422-8a72-e052d8cd1bd9",
     "environment": "spo",
     "packageManager": "npm",
     "solutionName": "react-application-news-ticker",

samples/react-application-news-ticker/README.md

@@ -8,8 +8,8 @@ An SPFx Extension that displays news as a running text at the top of every moder
 
 ## Compatibility
 
-![SPFx 1.14.0](https://img.shields.io/badge/SPFx-1.14.0-green.svg)
-![Node.js LTS v14 | LTS v12 | LTS v10](https://img.shields.io/badge/Node.js-LTS%20v14%20%7C%20LTS%20v12%20%7C%20LTS%20v10-green.svg) 
+![SPFx 1.15.2](https://img.shields.io/badge/SPFx-1.15.2-green.svg)
+![Node.js LTS v14](https://img.shields.io/badge/Node.js-LTS%20v14-green.svg) 
 ![Compatible with SharePoint Online](https://img.shields.io/badge/SharePoint%20Online-Compatible-green.svg)
 ![Does not work with SharePoint 2019](https://img.shields.io/badge/SharePoint%20Server%202019-Incompatible-red.svg "SharePoint Server 2019 requires SPFx 1.4.1 or lower")
 ![Does not work with SharePoint 2016 (Feature Pack 2)](https://img.shields.io/badge/SharePoint%20Server%202016%20(Feature%20Pack%202)-Incompatible-red.svg "SharePoint Server 2016 Feature Pack 2 requires SPFx 1.1")
@@ -51,6 +51,7 @@ Version|Date|Comments
 -------|----|--------
 1.0|April 19, 2021|Initial release
 1.1|October 17, 2021|Update SPFx version to 1.12.1
+1.2|August 27, 2021|Fixed failed upgrade and update SPFx version to 1.15.2
 
 
 ## Minimal Path to Awesome
@@ -61,8 +62,6 @@ Version|Date|Comments
   - `npm install`
   - `gulp serve`
 
-> Include any additional steps as needed.
-
 ## Features
 
 This extension illustrates the following concepts:
@@ -82,7 +81,7 @@ This extension illustrates the following concepts:
 Here's a debug URL for testing around this sample. 
 
 ```
-?debugManifestsFile=https://localhost:4321/temp/manifests.js&loadSPFX=true&customActions={"4358e70e-ec3c-4713-beb6-39c88f7621d1":{"location":"ClientSideExtension.ApplicationCustomizer","properties":{"listTitle":"News","listViewTitle":"Published News"}}}
+?debugManifestsFile=https://localhost:4321/temp/manifests.js&loadSPFX=true&customActions={"4358e70e-ec3c-4713-beb6-39c88f7621d1":{"location":"ClientSideExtension.ApplicationCustomizer","properties":{"listTitle":"News","listViewTitle":"Published+News","bgColor":"%2348c78e","textColor":"white"}}}
 ```
 
 ## Disclaimer
@@ -92,12 +91,14 @@ Here's a debug URL for testing around this sample.
 
 We do not support samples, but we this community is always willing to help, and we want to improve these samples. We use GitHub to track issues, which makes it easy for  community members to volunteer their time and help resolve issues.
 
-You can try looking at [issues related to this sample](https://github.com/pnp/sp-dev-fx-extensions/issues?q=label%3Areact-application-news-ticker) to see if anybody else is having the same issues.
+You can try looking at [issues related to this sample](https://github.com/pnp/sp-dev-fx-extensions/issues?q=label%3Asample%3Areact-application-news-ticker) to see if anybody else is having the same issues.
+
+You can also try looking at [discussions related to this sample](https://github.com/pnp/sp-dev-fx-extensions/discussions?discussions_q=label%3Asample%3Areact-application-news-ticker) and see what the community is saying.
 
-You can also try looking at [discussions related to this sample](https://github.com/pnp/sp-dev-fx-extensions/discussions?discussions_q=label%3Areact-application-news-ticker) and see what the community is saying.
+If you encounter any issues while using this sample, [create a new issue](https://github.com/pnp/sp-dev-fx-extensions/issues/new?assignees=&labels=Needs%3A+Triage+%3Amag%3A%2Ctype%3Abug-suspected&template=bug-report.yml&sample=react-application-news-ticker&authors=@AriGunawan&title=react-application-news-ticker%20-%20).
 
-If you encounter any issues while using this sample, [create a new issue](https://github.com/pnp/sp-dev-fx-extensions/issues/new?assignees=&labels=Needs%3A+Triage+%3Amag%3A%2Ctype%3Abug-suspected&template=bug-report.yml&sample=react-application-news-ticker&authors=@YOURGITHUBUSERNAME&title=react-application-news-ticker%20-%20).
+For questions regarding this sample, [create a new question](https://github.com/pnp/sp-dev-fx-extensions/issues/new?assignees=&labels=Needs%3A+Triage+%3Amag%3A%2Ctype%3Abug-suspected&template=question.yml&sample=react-application-news-ticker&authors=@AriGunawan&title=react-application-news-ticker%20-%20).
 
-For questions regarding this sample, [create a new question](https://github.com/pnp/sp-dev-fx-extensions/issues/new?assignees=&labels=Needs%3A+Triage+%3Amag%3A%2Ctype%3Abug-suspected&template=question.yml&sample=react-application-news-ticker&authors=@YOURGITHUBUSERNAME&title=react-application-news-ticker%20-%20).
+Finally, if you have an idea for improvement, [make a suggestion](https://github.com/pnp/sp-dev-fx-extensions/issues/new?assignees=&labels=Needs%3A+Triage+%3Amag%3A%2Ctype%3Abug-suspected&template=suggestion.yml&sample=react-application-news-ticker&authors=@AriGunawan&title=react-application-news-ticker%20-%20).
 
-Finally, if you have an idea for improvement, [make a suggestion](https://github.com/pnp/sp-dev-fx-extensions/issues/new?assignees=&labels=Needs%3A+Triage+%3Amag%3A%2Ctype%3Abug-suspected&template=suggestion.yml&sample=react-application-news-ticker&authors=@YOURGITHUBUSERNAME&title=react-application-news-ticker%20-%20).
+<img src="https://pnptelemetry.azurewebsites.net/sp-dev-fx-extensions/samples/react-application-news-ticker" />

samples/react-application-news-ticker/config/package-solution.json

@@ -1,9 +1,9 @@
 {
   "$schema": "https://developer.microsoft.com/json-schemas/spfx-build/package-solution.schema.json",
   "solution": {
-    "name": "react-application-news-ticker-client-side-solution",
-    "id": "b5d9ad1f-5198-4647-a5b6-5dbc17bf1608",
-    "version": "1.0.0.0",
+    "name": "React News Ticker",
+    "id": "65603ca8-004c-469c-8b6f-b24ef5f2e794",
+    "version": "1.2.0.0",
     "includeClientSideAssets": true,
     "skipFeatureDeployment": true,
     "isDomainIsolated": false,
@@ -12,7 +12,7 @@
       "websiteUrl": "",
       "privacyUrl": "",
       "termsOfUseUrl": "",
-      "mpnId": "Undefined-1.14.0"
+      "mpnId": "Undefined-1.15.2"
     },
     "metadata": {
       "shortDescription": {
@@ -29,7 +29,7 @@
       {
         "title": "Application Extension - Deployment of custom action",
         "description": "Deploys a custom action with ClientSideComponentId association",
-        "id": "73d57e47-1fd2-4f03-81d9-b2ecccd76c51",
+        "id": "632826fc-01ff-49ce-b6c1-90c48e4b513a",
         "version": "1.0.0.0",
         "assets": {
           "elementManifests": [
@@ -41,6 +41,6 @@
     ]
   },
   "paths": {
-    "zippedPackage": "solution/react-application-news-ticker.sppkg"
+    "zippedPackage": "solution/React News Ticker.sppkg"
   }
 }

samples/react-application-news-ticker/config/serve.json

@@ -6,7 +6,7 @@
         "default": {
             "pageUrl": "https://contoso.sharepoint.com/sites/mySite/SitePages/myPage.aspx",
             "customActions": {
-                "31a709b3-310f-4e85-bf46-b2bdd17af44d": {
+                "4358e70e-ec3c-4713-beb6-39c88f7621d1": {
                     "location": "ClientSideExtension.ApplicationCustomizer",
                     "properties": {
                         "listTitle": "News",
@@ -20,7 +20,7 @@
         "newsTicker": {
             "pageUrl": "https://contoso.sharepoint.com/sites/mySite/SitePages/myPage.aspx",
             "customActions": {
-                "31a709b3-310f-4e85-bf46-b2bdd17af44d": {
+                "4358e70e-ec3c-4713-beb6-39c88f7621d1": {
                     "location": "ClientSideExtension.ApplicationCustomizer",
                     "properties": {
                         "listTitle": "News",

samples/react-application-news-ticker/gulpfile.js

@@ -18,5 +18,10 @@ const { addFastServe } = require("spfx-fast-serve-helpers");
 addFastServe(build);
 /* end of fast-serve */
 
+// ********* PNPJS *******
+// disable tslint
+build.tslintCmd.enabled = false;
+// ********* PNPJS *******
+
 build.initialize(require('gulp'));