react-application-nav-search-driven Upgrade to SPFx 1.20.0 #1436
+5,829
−4,573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adam-it
requested changes
Oct 22, 2024
There was a problem hiding this comment.
@dgirase Awesome work 👏👏👏
We are really close and I only notes some few minor things we should sort out before we merge. Please do give the a double check 🙏
Also we should update the assets/sample.json file. We should update the updateDateTime and SPFX-VERSION metadata in this file
|
@dgirase are you still working on this? If the PR is ready for review please click on the 'Ready for review' button to let us know |
|
@dgirase were you able to build the solution? I tried to test it but I wasn't able to create the package |
|
I have resolved the issue of package-solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?