Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade react-application-tenant-global-navbar to spfx v1.20.0, refactor, fix & optimize #1417

Merged
merged 3 commits into from
Oct 7, 2024
Merged

upgrade react-application-tenant-global-navbar to spfx v1.20.0, refactor, fix & optimize #1417

merged 3 commits into from
Oct 7, 2024

Conversation

tom-daly
Copy link
Contributor

@tom-daly tom-daly commented Oct 2, 2024

By submitting this pull request, you agree to the contribution guidelines

If you aren't familiar with how to contribute to open-source repositories using GitHub, or if you find the instructions on this page confusing, sign up for one of our Sharing is Caring events. It's completely free, and we'll guide you through the process.

Q A
Bug fix? no
New feature? no
New sample? no
Related issues? #1409

What's in this Pull Request?

  • Upgrade solution from SPFx v1.2.0 to v1.20.0
  • Replace old Office UI Fabric with Fluent UI React
  • Update ReadMe to include setup for the Term Store
  • Added a default properties for the Header/Footer Term Sets
  • Rebuild the Header/Footer controls as functional components + optimize code redundancies

@tom-daly tom-daly changed the title upgrade to spfx v1.20.0, refactor, fix & optimize upgrade react-application-tenant-global-navbar to spfx v1.20.0, refactor, fix & optimize Oct 5, 2024
@Adam-it Adam-it self-assigned this Oct 6, 2024
Adam-it
Adam-it approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tom-daly Awesome work 👏👏👏👏
I liked the fact how you refactored the code and added more guidance o the sample 👍
You Rock 🤩
I managed to test it out and didn't have any blocking comments. Lets 🚢 it

samples/react-application-tenant-global-navbar/build.cmd Show resolved Hide resolved
samples/react-application-tenant-global-navbar/package.json Show resolved Hide resolved
@Adam-it Adam-it linked an issue Oct 7, 2024 that may be closed by this pull request
Upgrade Tenant Global NavBar Application Customizer extension to latest version of SPFx - Refresh Rangers Hacktoberfest Event #1409
Closed
@Adam-it Adam-it merged commit 7d38600 into pnp:main Oct 7, 2024
5 checks passed
@tom-daly tom-daly deleted the upgrade-react-application-tenant-global-navbar branch October 10, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adam-it Adam-it Adam-it approved these changes

Assignees

@Adam-it Adam-it

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tom-daly @Adam-it