Skip to content

Commit

Permalink
Upgrade Field Votes extension to latest version of SPFx
Browse files Browse the repository at this point in the history
* Upgrade to SPFx 1.20.0 and PnPJS 4.6

* fixup

---------

Co-authored-by: Adam Wójcik <[email protected]>
  • Loading branch information
ervingayle and Adam-it authored Oct 29, 2024
1 parent e150b1f commit 4789164
Show file tree
Hide file tree
Showing 14 changed files with 33,644 additions and 42,591 deletions.
2 changes: 1 addition & 1 deletion samples/react-field-votes/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ module.exports = {
//
// CONFIGURATION: By default, these are banned: String, Boolean, Number, Object, Symbol
'@typescript-eslint/ban-types': [
1,
0,
{
'extendDefaults': false,
'types': {
Expand Down
Binary file modified samples/react-field-votes/.nvmrc
Binary file not shown.
7 changes: 5 additions & 2 deletions samples/react-field-votes/.yo-rc.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"@microsoft/generator-sharepoint": {
"plusBeta": false,
"isCreatingSolution": true,
"version": "1.15.2",
"version": "1.20.0",
"libraryName": "react-field-votes",
"libraryId": "2a2ccbf6-44a6-44a5-8129-068602b64e19",
"environment": "spo",
Expand All @@ -12,6 +12,9 @@
"skipFeatureDeployment": true,
"isDomainIsolated": false,
"componentType": "extension",
"extensionType": "FieldCustomizer"
"extensionType": "FieldCustomizer",
"sdkVersions": {
"@microsoft/teams-js": "2.24.0"
}
}
}
6 changes: 4 additions & 2 deletions samples/react-field-votes/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ When a user clicks the 'vote' button, it will append the current user to the exi

## Compatibility

![SPFx 1.15.2](https://img.shields.io/badge/SPFx-1.15.2-green.svg)
![Node.js v14 | v16](https://img.shields.io/badge/Node.js-v14%20%7C%20v16-green.svg)
![SPFx 1.20.0](https://img.shields.io/badge/SPFx-1.20.0-green.svg)
![Node.js v18](https://img.shields.io/badge/Node.js-v18-green.svg)
![Compatible with SharePoint Online](https://img.shields.io/badge/SharePoint%20Online-Compatible-green.svg)
![Local Workbench Unsupported](https://img.shields.io/badge/Local%20Workbench-Unsupported-red.svg "Local workbench is no longer available as of SPFx 1.13 and above")

Expand All @@ -28,11 +28,13 @@ When a user clicks the 'vote' button, it will append the current user to the exi
## Contributors

* [Ari Gunawan](https://github.com/AriGunawan)
* [Ervin Gayle](https://github.com/ErvinGayle)

## Version history

Version|Date|Comments
-------|----|--------
1.5|October 26, 2024|Updated SPFx packages to 1.20.0
1.4|October 8, 2023|Change underlying field type from JSON text to multiple person
1.3|October 18, 2022|Change underlying field type from multiline text to multiple person
1.2|October 18, 2022|Initial version
Expand Down
4 changes: 2 additions & 2 deletions samples/react-field-votes/assets/sample.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"If the current user hasn't been voted, the button will become Vote button but if the current user has been voted, it will become Unvote button."
],
"creationDateTime": "2021-04-19",
"updateDateTime": "2023-10-08",
"updateDateTime": "2024-10-29",
"products": [
"SharePoint"
],
Expand All @@ -21,7 +21,7 @@
},
{
"key": "SPFX-VERSION",
"value": "1.15.2"
"value": "1.20.0"
}
],
"categories": [
Expand Down
4 changes: 2 additions & 2 deletions samples/react-field-votes/config/package-solution.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"solution": {
"name": "React Field Votes",
"id": "2a2ccbf6-44a6-44a5-8129-068602b64e19",
"version": "1.3.0.0",
"version": "1.5.0.0",
"includeClientSideAssets": true,
"skipFeatureDeployment": true,
"isDomainIsolated": false,
Expand All @@ -30,7 +30,7 @@
"title": "Application Extension - Deployment of custom action",
"description": "Deploys a custom action with ClientSideComponentId association",
"id": "6f0dec15-af81-4377-96bc-af3fb96c2964",
"version": "1.0.0.0",
"version": "1.5.0.0",
"assets": {
"elementManifests": [
"elements.xml"
Expand Down
3 changes: 3 additions & 0 deletions samples/react-field-votes/config/saas.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"$schema": "https://developer.microsoft.com/json-schemas/core-build/sass.schema.json"
}
Loading

0 comments on commit 4789164

Please sign in to comment.