-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #1775 and #1760 #1781
Open
wuxiaojun514
wants to merge
7
commits into
pnp:dev
Choose a base branch
from
wuxiaojun514:dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix for #1775 and #1760 #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for taking care of this issue!!! |
When will be this fix available? When we will have a new release? |
Waiting for #1726 |
Migrate from Original Dev Branch
@joelfmrodrigues any news about this issue? We hope to have a resolution |
Merge from Main Dev Branch to my personal dev branch
Sync the latest dev branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
This pull request is to fix two issues on required field validation issues in Dynamic Form control
Dynamic Form has done huge refactoring on version 3.17. See pull request 1672 for detail
The root cause of issue #1760 is due to the initial value of
newValue
has been changed from "null" to "undefined". So I modified the related code to "undefined" as well.Regarding #1775 , now
changedValue
won't use loaded item's value as initial value. So I added another check to compare withvalue
when there is no new value on this field.