Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libpng18] Remove AM_MAINTAINER_MODE from configure.ac #595

Closed
wants to merge 1 commit into from

Conversation

jbowler
Copy link
Contributor

@jbowler jbowler commented Sep 15, 2024

Now the autoconf generated files are no longer in the source in libpng18
AM_MAINTAINER_MODE is not required; the generated files must have the
correct timestamp.

This change is essential in a development environment where "git pull"
may update configure.ac, Makefile.am because NOW the pull does not
update configure and Makefile.in as well. This solves a lot of problems
but not when AM_MAINTAINER_MODE is in configure.ac where it just creates
a complete mess; configure and Makefile.in don't get updated and
mysterious (to the puller) build failures happen.

Note that 'configure --enable-maintainer-mode' is incompatible with
doing builds for different architectures in parallel; it ends up with
two configure processes overwriting stuff in ${srcdir}.

To generate a tarball run configure with "--disable-maintainer-mode".
See the discussion in paragraph 5 of section 26.2.2 of the GNU automake
manual (1.7.4).

Now the autoconf generated files are no longer in the source in libpng18
AM_MAINTAINER_MODE is not required; the generated files must have the
correct timestamp.

This change is essential in a development environment where "git pull"
may update configure.ac, Makefile.am because NOW the pull does not
update configure and Makefile.in as well.  This solves a lot of problems
but not when AM_MAINTAINER_MODE is in configure.ac where it just creates
a complete mess; configure and Makefile.in don't get updated and
mysterious (to the puller) build failures happen.

Note that 'configure --enable-maintainer-mode' is incompatible with
doing builds for different architectures in parallel; it ends up with
two configure processes overwriting stuff in ${srcdir}.

To generate a tarball run configure with "--disable-maintainer-mode".
See the discussion in paragraph 5 of section 26.2.2 of the GNU automake
manual (1.7.4).

Signed-off-by: John Bowler <[email protected]>
@jbowler jbowler changed the base branch from libpng16 to libpng18 September 15, 2024 17:48
@jbowler jbowler changed the title Remove AM_MAINTAINER_MODE from configure.ac [libpng18] Remove AM_MAINTAINER_MODE from configure.ac Sep 15, 2024
@ctruta
Copy link
Member

ctruta commented Sep 20, 2024

Integrated.

@ctruta ctruta closed this Sep 20, 2024
@jbowler jbowler deleted the AM_MAINTAINER_MODE branch September 21, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants