feat!: React 18 and 19 support #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a848f44 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a848f44:
|
|
cc/ @dbismut @CodyJasonBennett for review |
|
any news please? |
CodyJasonBennett
changed the title
CodyJasonBennett
changed the title
|
🙌 thanks @CodyJasonBennett! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This library is incompatible with React 19 because it's usage of
ReactDOM.renderwhich has been dropped in v19.I've changed the usage of that to
createRootand increased the required react and react-dom versions to v18.This will be a new major version as it is a breaking change to all users not on at least v18.
Testing
I tried running the tests but they were failing for me. They were failing before I made any changes with:
After the changes they're failing with:
I think that means there's multiple versions of React being bundled, but I wasn't able to figure out how to debug that.