Protocol changes for 1.21.20 #260
Conversation
|
There seems to be an additional field for the ItemUseInventoryTransaction type.
|
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
in terms of the world, i'm pretty sure the solution is to update the blockstates nbt file that provides the runtime block map to the server |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Can you moove into discord or smth and resume here when you're done ? |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@fBNTFeujjj @AzOxStOz @JblusItsMe Move your conversation elsewhere and it's make difficult for those who are interested in reviewing the PR |
|
Please don't force-push |
src/types/inventory/stackrequest/CraftRecipeAutoStackRequestAction.php
Outdated
Show resolved
Hide resolved
src/types/inventory/stackrequest/CraftRecipeStackRequestAction.php
Outdated
Show resolved
Hide resolved
src/types/inventory/stackrequest/CreativeCreateStackRequestAction.php
Outdated
Show resolved
Hide resolved
src/types/inventory/stackrequest/GrindstoneStackRequestAction.php
Outdated
Show resolved
Hide resolved
| @@ -50,16 +53,18 @@ public function getIngredients() : array{ return $this->ingredients; } | |||
|
|
|||
| public static function read(PacketSerializer $in) : self{ | |||
| $recipeId = $in->readRecipeNetId(); | |||
| $repetitions2 = $in->getByte(); | |||
There was a problem hiding this comment.
i know it's mojang fault, but it doesn't have too much sense to repetitions2 is before repetitions
| $out->putBool($this->message === null); | ||
| if($this->message !== null){ | ||
| $out->putString($this->message); | ||
| $out->putBool($skipMessage = $this->message === null && $this->filteredMessage === null); |
There was a problem hiding this comment.
This bool is not obvious what it is, what it does is to hide/skip the disconnection screen, please document this
| final class TakeFromBundleStackRequestAction extends ItemStackRequestAction{ | ||
| use GetTypeIdFromConstTrait; | ||
| use TakeOrPlaceStackRequestActionTrait; | ||
| enum ServerboundLoadingScreenPacketType : int{ |
There was a problem hiding this comment.
Serverbound is a prefix for packets, i think should not be in enums
No description provided.