Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name the packet according to convention #248

Merged
merged 1 commit into from
Jul 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@

use pocketmine\network\mcpe\protocol\serializer\PacketSerializer;

class CloseFormPacket extends DataPacket implements ClientboundPacket{
public const NETWORK_ID = ProtocolInfo::CLOSE_FORM_PACKET;
class ClientboundCloseFormPacket extends DataPacket implements ClientboundPacket{
public const NETWORK_ID = ProtocolInfo::CLIENTBOUND_CLOSE_FORM_PACKET;

/**
* @generate-create-func
Expand Down
2 changes: 1 addition & 1 deletion src/PacketHandlerDefaultImplTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -802,7 +802,7 @@ public function handleAwardAchievement(AwardAchievementPacket $packet) : bool{
return false;
}

public function handleCloseForm(CloseFormPacket $packet) : bool{
public function handleCloseForm(ClientboundCloseFormPacket $packet) : bool{
return false;
}
}
2 changes: 1 addition & 1 deletion src/PacketHandlerInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -408,5 +408,5 @@ public function handleSetHud(SetHudPacket $packet) : bool;

public function handleAwardAchievement(AwardAchievementPacket $packet) : bool;

public function handleCloseForm(CloseFormPacket $packet) : bool;
public function handleCloseForm(ClientboundCloseFormPacket $packet) : bool;
}
2 changes: 1 addition & 1 deletion src/PacketPool.php
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ public function __construct(){
$this->registerPacket(new SetPlayerInventoryOptionsPacket());
$this->registerPacket(new SetHudPacket());
$this->registerPacket(new AwardAchievementPacket());
$this->registerPacket(new CloseFormPacket());
$this->registerPacket(new ClientboundCloseFormPacket());
}

public function registerPacket(Packet $packet) : void{
Expand Down
2 changes: 1 addition & 1 deletion src/ProtocolInfo.php
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,6 @@ private function __construct(){
public const SET_PLAYER_INVENTORY_OPTIONS_PACKET = 0x133;
public const SET_HUD_PACKET = 0x134;
public const AWARD_ACHIEVEMENT_PACKET = 0x135;
public const CLOSE_FORM_PACKET = 0x136;
public const CLIENTBOUND_CLOSE_FORM_PACKET = 0x136;

}