Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize the headers to isolate the nonstandard routines #6

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Reorganize the headers to isolate the nonstandard routines #6

merged 2 commits into from
Apr 4, 2022

Conversation

jjhursey
Copy link
Member

@jjhursey jjhursey commented Mar 11, 2022 •
edited
Loading

  • Fixes todo: figure out what to do regarding static inlines in the standard #5
  • The non-standard supporting routines are in the pmix_abi_support(_bottom).h
    header to make them easily identified as non-standard.
  • Layer the headers to isolate the functions from the macros from the
    types and constants.
  • Add missing functions for
    • PMIx_Disconnect
    • PMIx_Disconnect_nb
    • PMIx_Info_load
    • PMIx_Info_xfer
  • Add a pmix.h that has the true function signatures

@jjhursey jjhursey force-pushed the reorg-n-doc branch 26 times, most recently from a07e3a5 to e7d48c6 Compare March 11, 2022 17:33
@jjhursey jjhursey requested review from rhc54 and raffenet March 11, 2022 17:34
@jjhursey jjhursey marked this pull request as ready for review March 11, 2022 17:34
@jjhursey
Copy link
Member Author

I'm not sure how we want to test this repo. I took care to make sure everything is ordered properly but didn't try to build anything against this. Any ideas?

@jjhursey
Copy link
Member Author

FYI: I filed #7 to discuss testing of this repo. #1 is the place to talk about long-term maintenance and updating.

@jjhursey jjhursey requested a review from dsolt March 14, 2022 18:43
@jjhursey jjhursey mentioned this pull request Mar 15, 2022
Closed
12 tasks
raffenet
raffenet reviewed Mar 15, 2022
View reviewed changes
pmix_macros.h Outdated Show resolved Hide resolved
dsolt
dsolt approved these changes Mar 28, 2022
View reviewed changes
Copy link

@dsolt dsolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me. I have not yet tried to compile codes with them, but I will do that next. The presentation/organization looks good.

@jjhursey
Reorganize the headers to isolate the nonstandard routines
d13069d 
 * Fixes pmix#5
 * The non-standard supporting routines are in the `pmix_abi_support(_bottom).h`
   header to make them easily identified as non-standard.
 * Layer the headers to isolate the functions from the macros from the
   types and constants.
 * Add missing functions for
   * `PMIx_Disconnect`
   * `PMIx_Disconnect_nb`
   * `PMIx_Info_load`
   * `PMIx_Info_xfer`
 * Add a `pmix.h` that has the true function signatures
@jjhursey
Add documentation
3d6bdf4 
Signed-off-by: Joshua Hursey <[email protected]>
@jjhursey
Copy link
Member Author

jjhursey commented Apr 4, 2022

Let's merge this and iterate a bit on master as we work out any details that crop up in broader testing.

@jjhursey jjhursey merged commit 11f4a25 into pmix:main Apr 4, 2022
@jjhursey jjhursey deleted the reorg-n-doc branch April 4, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raffenet raffenet raffenet left review comments

@dsolt dsolt dsolt approved these changes

@rhc54 rhc54 Awaiting requested review from rhc54

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

todo: figure out what to do regarding static inlines in the standard
3 participants
@jjhursey @raffenet @dsolt