Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do we test this repo? #7

Open
jjhursey opened this issue Mar 11, 2022 · 4 comments
Open

How do we test this repo? #7

jjhursey opened this issue Mar 11, 2022 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@jjhursey
Copy link
Member

We should have a set of tests that we can build to check that the headers inside this repo are complete and functional.

@rhc54
Copy link
Member

rhc54 commented Mar 11, 2022

You could use the dlopen branch of the MPIR shim, I suppose. Needs a little TLC, but you could simply re-use the current shim test for it.

🤷‍♂️ Wouldn't cover everything, but it would be a relatively simple place to start.

@jjhursey
Copy link
Member Author

A few notes from the IA WG call on March 14, 2022

  • ABI Compliance Checker: https://lvc.github.io/abi-compliance-checker/
    • Might be able to use between OpenPMix and the headers in this repo
  • MPIR-Shim dlopen branch testing for the dlopen headers.
  • Take some of the OpenPMIx tests and compile with PMIx ABI headers and link against OpenPMIx.

@raffenet
Copy link
Contributor

raffenet commented Apr 8, 2022

Here an example report generated from ABI Compliance Checker. This compares OpenPMIx 4.1.2 vs the pmix-abi repo headers: https://www.mcs.anl.gov/~raffenet/compat_report.html

@raffenet
Copy link
Contributor

Here an example report generated from ABI Compliance Checker. This compares OpenPMIx 4.1.2 vs the pmix-abi repo headers: https://www.mcs.anl.gov/~raffenet/compat_report.html

I updated the compatibility report at https://www.mcs.anl.gov/~raffenet/compat_report.html. It now uses the OpenPMIx master branch @ d8eeab2c0ec8d84f2f3cabc3062c1a5234f88b44 and includes the pmix_server.h and pmix_tool.h header files I omitted the first time. I also reversed the order of the compliance checker so that it uses the pmix-abi repo as the base version and flags differences in OpenPMIx, which are all additions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants