-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Timeslot) Timeslot V1 with 2 ranges but no margin option #22
Conversation
Lainow
commented
Feb 1, 2024
a4a4a4e
to
64408ee
Compare
I'd like your review of the JS part (it's not my area of expertise =) ) |
* ------------------------------------------------------------------------- | ||
*/ | ||
|
||
var AJAX_URL = CFG_GLPI.root_doc + '/' + GLPI_PLUGINS_PATH.deploy + '/ajax/timeslot.php'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contents of this script should be encapsulated somehow to avoid adding/overwriting anything in the global scope. As far as I can tell, nothing outside this script calls any of the functions or uses any of the variables.
Co-authored-by: Curtis Conard <[email protected]>
Co-authored-by: Curtis Conard <[email protected]>
Co-authored-by: Curtis Conard <[email protected]>
Co-authored-by: Curtis Conard <[email protected]>
Co-authored-by: Curtis Conard <[email protected]>
Co-authored-by: Curtis Conard <[email protected]>
as a final step with a final review We need to add add update this view to choose the timeslot when selecting the computer group and display it in the table below |
waiting for the CI Continuous integration to be adapted to GLPI 11.0.x |