feat(Timeslot) Timeslot V1 with 2 ranges but no margin option #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Lainow
commented
Feb 1, 2024
Lainow
commented
Lainow
force-pushed
the
timeslot
branch
3 times, most recently
from
a4a4a4e
to
64408ee
Compare
|
I'd like your review of the JS part (it's not my area of expertise =) ) |
cconard96
suggested changes
Feb 12, 2024
| * ------------------------------------------------------------------------- | ||
| */ | ||
|
|
||
| var AJAX_URL = CFG_GLPI.root_doc + '/' + GLPI_PLUGINS_PATH.deploy + '/ajax/timeslot.php'; |
There was a problem hiding this comment.
The contents of this script should be encapsulated somehow to avoid adding/overwriting anything in the global scope. As far as I can tell, nothing outside this script calls any of the functions or uses any of the variables.
Co-authored-by: Curtis Conard <[email protected]>
Co-authored-by: Curtis Conard <[email protected]>
Co-authored-by: Curtis Conard <[email protected]>
Co-authored-by: Curtis Conard <[email protected]>
Co-authored-by: Curtis Conard <[email protected]>
Co-authored-by: Curtis Conard <[email protected]>
|
as a final step with a final review We need to add add update this view
to choose the timeslot when selecting the computer group and display it in the table below |
|
waiting for the CI Continuous integration to be adapted to GLPI 11.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.