Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl Color for f64 (+ f32, i64, i32, ...) #155

Merged
merged 7 commits into from
Jun 19, 2024

Conversation

tectin0
Copy link
Contributor

@tectin0 tectin0 commented Aug 8, 2023

Hey there!

I noticed that someone had raised an issue regarding the removal of impl Color for f64 in a previous version (#141). I also had this issue and to be honest, I don't even know how one would use the colorscales with a scatter plot without being able to use a reference vector.

I went ahead and created a very simple pull request to reimplement it, along with impl Color for other types (f32, i64, i32, ...).

Additionally, I expanded the 3d_charts example to include a plot that showcases the now working colorscales.
I also fixed the customized_scatter3d_plot() where colorscales were not working because of this.

If there is any reason why this wouldn't just work like this please let me know.

newplot (1)

newplot (2)

@andrei-ng andrei-ng self-assigned this Jun 12, 2024
@andrei-ng
Copy link
Collaborator

andrei-ng commented Jun 19, 2024

Thanks for the PR! Will merge it.

@andrei-ng andrei-ng merged commit 0071831 into plotly:main Jun 19, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants