Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine adding 'shared' files with 'min' files in _js_dist #143

Closed
wants to merge 1 commit into from

Conversation

TillerBurr
Copy link

This fixes #142

To reduce code duplication, the -shared in webpack.config.js was changed to .shared. Then this can be combined with the extension of the _js_dist using the min version.

Since it is hard to tell if there is a shared file until it is generated, a shared_resources list was created that defaults to ["min"]. If a shared file is generated, then 'shared' would need to be appended to this list. Without checking to see if a file exists, this is simplest fix I could think of.

@TillerBurr TillerBurr closed this Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shared files are not served, if generated.
1 participant