Combine adding 'shared' files with 'min' files in _js_dist
#143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #142
To reduce code duplication, the
-shared
in webpack.config.js was changed to.shared
. Then this can be combined with the extension of the_js_dist
using themin
version.Since it is hard to tell if there is a shared file until it is generated, a
shared_resources
list was created that defaults to["min"]
. If a shared file is generated, then 'shared' would need to be appended to this list. Without checking to see if a file exists, this is simplest fix I could think of.