Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix a typo #839

Merged
merged 2 commits into from
Feb 21, 2024
Merged

fix: Fix a typo #839

merged 2 commits into from
Feb 21, 2024

Conversation

muditchoudhary
Copy link
Contributor

@muditchoudhary muditchoudhary commented Feb 21, 2024

Fix a very little typo.

I, Mudit Choudhary, agree to have this contribution published under Creative Commons 4.0 International License (CC BY 4.0), with attribution to the Plone Foundation.

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for plone-training ready!

Name Link
🔨 Latest commit 0cf5a2a
🔍 Latest deploy log https://app.netlify.com/sites/plone-training/deploys/65d5ba51a605eb00087c71b3
😎 Deploy Preview https://deploy-preview-839--plone-training.netlify.app/mastering-plone/features
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -274,7 +274,7 @@ Page

News Item

: Basically a page with an image and an image caption to be used for press releases an such.
: Basically a page with an image and an image caption to be used for press releases as such.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"and such" is the correct English phrase.

Suggested change
: Basically a page with an image and an image caption to be used for press releases as such.
: Basically a page with an image and an image caption to be used for press releases and such.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes! Thanks!

@stevepiercy
Copy link
Contributor

@muditchoudhary before this can be merged, please follow the instructions in https://training.plone.org/contributing/. Thank youi!

@muditchoudhary
Copy link
Contributor Author

@muditchoudhary before this can be merged, please follow the instructions in https://training.plone.org/contributing/. Thank youi!

I have read that. I think I misunderstood this as optional:

In every pull request or commit message, include the following statement.

@stevepiercy
Copy link
Contributor

@muditchoudhary Plone cannot publish your contribution without your express written consent using one of the two options. If you plan on making more contributions, then the Plone Contributor Agreement would be better, but it takes a few days for volunteers to process. You could do both options, too, allowing us to merge this now and your future contributions without getting nagged by the bot.

@muditchoudhary
Copy link
Contributor Author

muditchoudhary commented Feb 21, 2024

@stevepiercy Yes, I have read in the docs. I have already signed the agreement and it did get processed by the volunteer. Thank you! for reminding

@stevepiercy
Copy link
Contributor

Thank you! Merging.

@stevepiercy stevepiercy merged commit 12d0b30 into plone:main Feb 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants