-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add query param to search registry records. #1861
Conversation
@Faakhir30 thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
Anyone know why Jenkins CI for 6.0/3.11 and 6.1/3.12 do not show up on the build history? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor improvements to docs and news.
Direct link to docs preview: @Faakhir30 thank you for your work on this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove the extra blank line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs and news LGTM, and it's all green. Let's get a technical review, too. Thank you! This is really nice. I think @gforcada would be interested in this.
@stevepiercy We have Jenkins configured to only run jobs for the oldest and newest version of Python supported by each version of Plone, to save some CPU cycles/carbon (so currently Python 3.9 and 3.13 for Plone 6.0, and Python 3.10 and 3.13 for Plone 6.1). I updated the required jobs in the branch protection settings for this repository so it should no longer show the others. I'll review this in the next day or two. Today was a holiday so I'm not spending much time at my computer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. A couple changes please:
Thank you! |
closes #1859
Added query param to filter out records, and returning only records with
key
that startswithq
param on listing registry service.Created a tmp registery with filtered records, serialize registry, return :)
📚 Documentation preview 📚: https://plonerestapi--1861.org.readthedocs.build/