Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to check for backend support of version-dependent features via the site service #1826

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

davisagli
Copy link
Member

@davisagli davisagli commented Oct 17, 2024

I need this because some new filters were added in CMFPlone for the URL Management control panel, and I want to add support for them in volto, but it needs to check whether it's talking to a backend that supports them.


📚 Documentation preview 📚: https://plonerestapi--1826.org.readthedocs.build/

@mister-roboto
Copy link

@davisagli thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@davisagli
Copy link
Member Author

@jenkins-plone-org please run jobs

Copy link
Member

@fredvd fredvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davisagli
Copy link
Member Author

@jenkins-plone-org please run jobs

@davisagli davisagli merged commit d6815a4 into main Oct 18, 2024
24 of 25 checks passed
@davisagli davisagli deleted the filter-aliases branch October 18, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants