Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logger initialization at add Allias by csv #1821

Merged
merged 7 commits into from
Oct 1, 2024
Merged

Conversation

Faakhir30
Copy link
Contributor

@Faakhir30 Faakhir30 commented Sep 30, 2024

Patch to #1813

  • Fixed logger's initialization.
  • Add check to check content-type of uploading file is CSV.

📚 Documentation preview 📚: https://plonerestapi--1821.org.readthedocs.build/

@mister-roboto
Copy link

@Faakhir30 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

news/1821.bugfix Outdated Show resolved Hide resolved
@davisagli davisagli merged commit 7a5fcf1 into main Oct 1, 2024
20 of 25 checks passed
@davisagli davisagli deleted the allias_by_csv branch October 1, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants