Docs: add section to upgrade guide for p.restapi 8 #1689
Conversation
|
@tisto thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
✅ Deploy Preview for plone-restapi ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: David Glick <[email protected]>
|
In the future, please do not delete deliberate blank lines before headings. They help authors find sections. Also there are some MyST syntax issues that need to be addressed. I am also concerned about the deletion of some lines. I don't know whether that was deliberate or accidental. I'll make a separate PR to resolve these issues, except for the last one, but I wanted to let y'all know. |
* Formatting fixes for #1689 * Add change log entry --------- Co-authored-by: Timo Stollenwerk <[email protected]>
|
Those lines were not deleted. I’m not sure why GitHub is showing them in
red but it’s a different red.
…On Thu, Aug 24, 2023 at 4:14 AM Steve Piercy ***@***.***> wrote:
In the future, please do not delete deliberate blank lines before
headings. They help authors find sections.
Also there are some MyST syntax issues that need to be addressed.
I am also concerned about the deletion of some lines
<https://github.com/plone/plone.restapi/pull/1689/files#diff-5181575a5b963d950ad39243e813f929f21691c3698835f2784db8fd692ccd51R710-R722>.
I don't know whether that was deliberate or accidental.
I'll make a separate PR to resolve these issues, except for the last one,
but I wanted to let y'all know.
—
Reply to this email directly, view it on GitHub
<#1689 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAL65X6VXDKFNFHAEFXF43XW4ZTDANCNFSM6AAAAAA335L6EI>
.
You are receiving this because you commented.Message ID: <plone/plone.
***@***.***>
|
|
Ah, I see. That's... odd formatting. |
No description provided.