Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow anonymous users to access @types endpoint #1423

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

erral
Copy link
Member

@erral erral commented May 9, 2022

Addresses #1409

@mister-roboto
Copy link

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@netlify
Copy link

netlify bot commented May 9, 2022

Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit 12197d7
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/64e84ead2fa12d0008a8e252

@erral erral marked this pull request as draft May 9, 2022 15:01
@tisto
Copy link
Member

tisto commented Aug 25, 2023

@erral what's the status of this PR? Can you elaborate your use case?

@erral
Copy link
Member Author

erral commented Aug 25, 2023

I don't recall why we added this PR...

I think it must be somehow related to the work we did during the Beethoven Sprint when we added in Volto a default view for schema based content-types

@davisagli
Copy link
Member

@tisto @erral I'm aware of 2 use cases that came up for this.

The first is the default schema-based view, like you said. That still does not work for anonymous users. But, this change stalled because there were some concerns about exposing private values in the schemas (such as vocabulary values).

The second is the use case of showing content type titles in listings. We solved that a different way in #1355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants