Better support for IQuerySource vocabularies #1078
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of named vocabularies. Better handling for vocabularies providing IQuerySource.
|
@alecpm thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
|
@alecpm LGTM. Thanks for the fix! Would it be possible to write a test for this or is this too much hassle? We have a testing profile where we could set up vocabularies I guess... |
tisto
approved these changes
Apr 7, 2021
✅ Deploy Preview for plone-restapi canceled.
|
|
Any takers to write a few tests? Then we could merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a couple small changes to help facilitate use of Async/AJAX select widgets with fields using a vocabulary providing
IQuerySource. It makes the following changes.vocabularyproperty of the field as well as thesource.vocabularyattribute to a value other than a vocabulary name string.This relates to issue #1077 and indirectly to #535.
CC: @pbauer @skleinfeldt