Replace dependency on noembed with python-oembed and list of providers #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This LGTM. Just the test needs some work, right? |
datakurre
force-pushed
the
no-more-noembed
branch
from
599cc5a to
6743496
Compare
|
@jensens Yes. Tests and maybe also some real life tests that there is no regression. Although, this should support more oEmbed providers than noembed did 🤔 Also, as mentioned, I am not sure if this is a patch, feature or breaking change. |
|
I would consider this as breaking. If someone run its own noembed server before it is no longer needed. So, it does not hurt to do a major release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embed tile has been depending on noembed-service, defaulting to the public service at https://noembed.com/ without instructions on how to host that by yourself.
This is an attempt to get rid of that service with pre-configured python-oembed consumer.
If accepted, I am not sure is this patch or a breaking change. Noembed.com seem to be not maintained anymore and there are immediate issues with it, requiring at least some fix. But then again, completely replacing it with embedded implementation is a breaking change.
https://community.plone.org/t/mosaic-embed-youtube-broke-noembed-com/13327/12