Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to non-functional Coveralls #543

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

stevepiercy
Copy link
Contributor

Coveralls has not worked since Travis CI was removed back in 2021(?). Documentation still shows it is being used. It hasn't been missed.

Coveralls has not worked since Travis CI was removed back in 2021(?). Documentation still shows it is being used. It hasn't been missed.

- Closes #537
- See #233, which I think should be closed.
@stevepiercy stevepiercy requested a review from ksuess December 7, 2024 06:46
@mister-roboto
Copy link

@stevepiercy thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@stevepiercy
Copy link
Contributor Author

@jenkins-plone-org please run jobs

@stevepiercy stevepiercy merged commit a6145e0 into master Dec 9, 2024
17 checks passed
@stevepiercy stevepiercy deleted the remove-unused-coveralls branch December 9, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Coverage on Coveralls is broken
3 participants