Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Being able to use schema.Time #1193

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Being able to use schema.Time #1193

merged 2 commits into from
Jan 23, 2024

Conversation

nilbacardit26
Copy link
Contributor

Let me know what you think.I tried schema.Time() but it did not work

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (93b4567) 94.6% compared to head (c3b3768) 94.1%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1193     +/-   ##
========================================
- Coverage    94.6%   94.1%   -0.4%     
========================================
  Files         377     377             
  Lines       32771   32803     +32     
========================================
- Hits        30991   30858    -133     
- Misses       1780    1945    +165     
Files Coverage Δ
guillotina/schema/_field.py 97.7% <100.0%> (+0.1%) ⬆️
guillotina/tests/test_api.py 99.7% <100.0%> (+0.1%) ⬆️
guillotina/tests/test_serialize.py 100.0% <100.0%> (ø)

... and 11 files with indirect coverage changes

@bloodbare bloodbare merged commit 41c45f0 into master Jan 23, 2024
22 checks passed
@bloodbare bloodbare deleted the time branch January 23, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants