Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding @update-catalog endpoint #1182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nilbacardit26
Copy link
Contributor

@nilbacardit26 nilbacardit26 commented Nov 27, 2022

This goes in conjunction with this:
plone/guillotina_elasticsearch#105

With ES nowadays, if we want to index new fields using index_field the only way to update the mappings and settings of the index using the API of guillotina is to do a POST to @ catalog, which deletes the whole index, and creates it again. Then we need to reindex all the data calling POST @catalog-reindex. With this change, (regarding ES) when adding new index fields we can just call @update-catalog and delegate the logic (if necessary) to the catalog utility.

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2022

Codecov Report

Merging #1182 (1964657) into master (6ee373b) will decrease coverage by 0.1%.
The diff coverage is 91.7%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1182     +/-   ##
========================================
- Coverage    94.7%   94.7%   -0.0%     
========================================
  Files         358     358             
  Lines       30700   30712     +12     
========================================
+ Hits        29069   29080     +11     
- Misses       1631    1632      +1     
Impacted Files Coverage Δ
guillotina/api/search.py 90.7% <87.5%> (-0.4%) ⬇️
guillotina/catalog/catalog.py 87.0% <100.0%> (+0.2%) ⬆️
guillotina/interfaces/catalog.py 100.0% <100.0%> (ø)
guillotina/tests/test_catalog.py 100.0% <100.0%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants