Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update declared Python support #4089

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Update declared Python support #4089

merged 4 commits into from
Jan 15, 2025

Conversation

davisagli
Copy link
Member

Plone 6.0.14 dropped support for Python 3.8 and added support for 3.13, as documented in plone/documentation#1823 and https://plone.org/download/release-schedule

@mister-roboto
Copy link

@davisagli thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@davisagli
Copy link
Member Author

@jenkins-plone-org please run jobs

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to only update the classifiers, and not touch python_requires.

Until now, our policy, or maybe just my own preference, was to not explicitly break support for Python 3.8. I think I have written or said this on occasion. If for some reason you still want to run Plone 6.0 on Python 3.8, you should be able to do so, without getting an error on installation because your Python version does not match with the python_requires setting.

You would be on your own for getting the correct versions of other packages, as our official versions.cfg may include versions that do not work on Python 3.8. And subtle things could go wrong, maybe someone starts using syntax that only works on Python 3.9+. I would actually consider that an error, which we could fix in a new release, if the effort is reasonable.

In short: unless we somehow know that Plone 6.0 cannot possibly run on Python 3.8, I think we should leave python_requires as it is.

Would you agree?

BTW, I do think we should start showing a warning in the Site Setup when using an outdated Python version, just like we do in Plone 5.2. Plus warn when Plone 6.0 is out of security support, but that will still be a few years. I would probably skip the warnings about being out of maintenance. But this can be something for another PR.

@davisagli
Copy link
Member Author

@mauritsvanrees I have some misgivings about it (it seems like it will make it too easy for someone to install a broken site with Python 3.8 but not realize it until they have a really obscure error) but I'll let you make the decision.

@mauritsvanrees mauritsvanrees merged commit 05d8e01 into 6.0.x Jan 15, 2025
2 of 4 checks passed
@mauritsvanrees mauritsvanrees deleted the 60-version-support branch January 15, 2025 14:59
@mauritsvanrees
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants