-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update declared Python support #4089
Conversation
@davisagli thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to only update the classifiers, and not touch python_requires
.
Until now, our policy, or maybe just my own preference, was to not explicitly break support for Python 3.8. I think I have written or said this on occasion. If for some reason you still want to run Plone 6.0 on Python 3.8, you should be able to do so, without getting an error on installation because your Python version does not match with the python_requires
setting.
You would be on your own for getting the correct versions of other packages, as our official versions.cfg
may include versions that do not work on Python 3.8. And subtle things could go wrong, maybe someone starts using syntax that only works on Python 3.9+. I would actually consider that an error, which we could fix in a new release, if the effort is reasonable.
In short: unless we somehow know that Plone 6.0 cannot possibly run on Python 3.8, I think we should leave python_requires
as it is.
Would you agree?
BTW, I do think we should start showing a warning in the Site Setup when using an outdated Python version, just like we do in Plone 5.2. Plus warn when Plone 6.0 is out of security support, but that will still be a few years. I would probably skip the warnings about being out of maintenance. But this can be something for another PR.
@mauritsvanrees I have some misgivings about it (it seems like it will make it too easy for someone to install a broken site with Python 3.8 but not realize it until they have a really obscure error) but I'll let you make the decision. |
Thanks! |
Plone 6.0.14 dropped support for Python 3.8 and added support for 3.13, as documented in plone/documentation#1823 and https://plone.org/download/release-schedule