Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set default notification timeout to 5 seconds #771

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

maxiroellplenty
Copy link
Contributor

@maxiroellplenty maxiroellplenty commented Oct 30, 2024

AB#133995

Why:

Closes: #ID

Describe your changes

Checklist before requesting a review

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I've updated docs/changelog/changelog_en.md and docs/changelog/changelog_de.md. If I'm a non-German speaker, I've still updated the file with the English version as a placeholder.

@maxiroellplenty maxiroellplenty requested a review from a team as a code owner October 30, 2024 16:40
@github-actions github-actions bot added the feature New feature or request label Oct 30, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 30, 2024
csandru-plenty
csandru-plenty previously approved these changes Oct 31, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 31, 2024
csandru-plenty
csandru-plenty previously approved these changes Oct 31, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 31, 2024
@maxiroellplenty maxiroellplenty merged commit f91e43b into main Oct 31, 2024
7 checks passed
@maxiroellplenty maxiroellplenty deleted the feat/default_notification_timeout branch October 31, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants